Add Google Workspace user account provisioning (#66)
* Add Google Workspace user account provisioning * Fix validation: remove stale skipGoogleUserProvisioning from a-akimov, add it for BobDickinson - a-akimov: had skipGoogleUserProvisioning but is not in a provisionUser role (DOCS_MAINTAINERS) - BobDickinson: is in REGISTRY_MAINTAINERS (provisionUser role) but missing Google user fields
This commit is contained in:
parent
d365a398cf
commit
2de77b8684
2 changed files with 502 additions and 23 deletions
|
|
@ -82,6 +82,51 @@ test('TYPESCRIPT_SDK_AUTH role exists (GitHub-only)', () => {
|
|||
return role !== undefined && role.github !== undefined && role.discord === undefined;
|
||||
});
|
||||
|
||||
// Test Google Workspace user provisioning
|
||||
test('Roles with provisionUser exist', () => {
|
||||
const provisionRoles = ROLES.filter((r) => r.google?.provisionUser);
|
||||
return provisionRoles.length > 0;
|
||||
});
|
||||
|
||||
test('Members with googleEmailPrefix have firstName and lastName', () =>
|
||||
MEMBERS.every((m) => {
|
||||
if (!m.googleEmailPrefix) return true;
|
||||
return !!m.firstName && !!m.lastName;
|
||||
}));
|
||||
|
||||
test('googleEmailPrefix values are unique', () => {
|
||||
const prefixes = MEMBERS.filter((m) => m.googleEmailPrefix).map((m) => m.googleEmailPrefix);
|
||||
return prefixes.length === new Set(prefixes).size;
|
||||
});
|
||||
|
||||
test('ProvisionUser members are explicit: fields present or skip flag set', () => {
|
||||
const provisionRoleIds = new Set(ROLES.filter((r) => r.google?.provisionUser).map((r) => r.id));
|
||||
return MEMBERS.every((member) => {
|
||||
const inProvisionRole = member.memberOf.some((id) => provisionRoleIds.has(id));
|
||||
if (!inProvisionRole) return !member.skipGoogleUserProvisioning;
|
||||
|
||||
const hasProvisioningFields = !!(
|
||||
member.firstName &&
|
||||
member.lastName &&
|
||||
member.googleEmailPrefix
|
||||
);
|
||||
return hasProvisioningFields !== !!member.skipGoogleUserProvisioning;
|
||||
});
|
||||
});
|
||||
|
||||
test('Some members in provisionUser roles have Google user fields', () => {
|
||||
const membersInProvisionRoles = MEMBERS.filter((m) =>
|
||||
m.memberOf.some((id) => {
|
||||
const role = roleLookup.get(id);
|
||||
return role?.google?.provisionUser === true;
|
||||
})
|
||||
);
|
||||
const provisioned = membersInProvisionRoles.filter(
|
||||
(m) => m.firstName && m.lastName && m.googleEmailPrefix
|
||||
);
|
||||
return membersInProvisionRoles.length > 0 && provisioned.length > 0;
|
||||
});
|
||||
|
||||
// Summary
|
||||
console.log(`\n${passed} passed, ${failed} failed`);
|
||||
process.exit(failed > 0 ? 1 : 0);
|
||||
|
|
|
|||
|
|
@ -98,6 +98,72 @@ console.log('Validating member ordering in users.ts...');
|
|||
}
|
||||
}
|
||||
|
||||
// Validate Google Workspace user provisioning fields
|
||||
console.log('Validating Google Workspace user provisioning fields...');
|
||||
{
|
||||
const googleEmailPrefixes = new Map<string, string>();
|
||||
|
||||
for (const member of MEMBERS) {
|
||||
const memberId = member.github || member.email || 'unknown';
|
||||
|
||||
// Members with googleEmailPrefix must also have firstName and lastName
|
||||
if (member.googleEmailPrefix) {
|
||||
if (!member.firstName) {
|
||||
console.error(`ERROR: Member "${memberId}" has googleEmailPrefix but is missing firstName`);
|
||||
hasErrors = true;
|
||||
}
|
||||
if (!member.lastName) {
|
||||
console.error(`ERROR: Member "${memberId}" has googleEmailPrefix but is missing lastName`);
|
||||
hasErrors = true;
|
||||
}
|
||||
|
||||
// Check uniqueness of googleEmailPrefix
|
||||
const existing = googleEmailPrefixes.get(member.googleEmailPrefix);
|
||||
if (existing) {
|
||||
console.error(
|
||||
`ERROR: googleEmailPrefix "${member.googleEmailPrefix}" is used by both "${existing}" and "${memberId}"`
|
||||
);
|
||||
hasErrors = true;
|
||||
} else {
|
||||
googleEmailPrefixes.set(member.googleEmailPrefix, memberId);
|
||||
}
|
||||
}
|
||||
|
||||
// Members in provisionUser roles without all three fields won't get a GWS account
|
||||
const inProvisionUserRole = member.memberOf.some((roleId: RoleId) => {
|
||||
const role = roleLookup.get(roleId);
|
||||
return role?.google?.provisionUser === true;
|
||||
});
|
||||
|
||||
const hasProvisioningFields = !!(
|
||||
member.googleEmailPrefix &&
|
||||
member.firstName &&
|
||||
member.lastName
|
||||
);
|
||||
|
||||
if (member.skipGoogleUserProvisioning && !inProvisionUserRole) {
|
||||
console.error(
|
||||
`ERROR: Member "${memberId}" has skipGoogleUserProvisioning=true but is not in a provisionUser role`
|
||||
);
|
||||
hasErrors = true;
|
||||
}
|
||||
|
||||
if (inProvisionUserRole && hasProvisioningFields && member.skipGoogleUserProvisioning) {
|
||||
console.error(
|
||||
`ERROR: Member "${memberId}" has provisioning fields and skipGoogleUserProvisioning=true; pick one`
|
||||
);
|
||||
hasErrors = true;
|
||||
}
|
||||
|
||||
if (inProvisionUserRole && !hasProvisioningFields && !member.skipGoogleUserProvisioning) {
|
||||
console.error(
|
||||
`ERROR: Member "${memberId}" is in a provisionUser role but is missing Google user fields. Add fields or set skipGoogleUserProvisioning: true`
|
||||
);
|
||||
hasErrors = true;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Validate parent role references in roles.ts
|
||||
console.log('Validating parent role references in roles.ts...');
|
||||
for (const role of ROLES) {
|
||||
|
|
|
|||
Loading…
Reference in a new issue