modelcontextprotocol/actions
Watch
1
0
Fork
You've already forked actions
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

slash-commands: keep maintainer-applied accepted label across pushes

Browse source 
When the approved label was most recently applied directly by a member of
always-allow-teams (i.e. a core maintainer using the GitHub UI) rather than by
the bot via /lgtm, treat it as a sticky governance decision and skip push
invalidation entirely. The bot-applied case (per-SHA /lgtm approval) still
invalidates as before.

Adds an invalidate-skipped result value and updates docs.

🏠 Remote-Dev: homespace
This commit is contained in:
Den Delimarsky 2026-04-24 00:51:19 +00:00
commit ae3da6a2dd
No known key found for this signature in database
1 changed files with 37 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

24
slash-commands/main.js
View file

@ -115,6 +115,17 @@ module.exports = async ({ github, context, core }) => {
return false;
}
async function lastLabeledBy(prNumber, labelName) {
const events = await github.paginate(github.rest.issues.listEvents, {
owner, repo, issue_number: prNumber, per_page: 100,
});
let actor = null;
for (const e of events) {
if (e.event === 'labeled' && e.label?.name === labelName) actor = e.actor;
}
return actor;
}
async function isAuthorized(user, pr) {
// 1. always-allow teams
if (await isInAlwaysAllowTeam(user)) return true;
@ -336,6 +347,19 @@ module.exports = async ({ github, context, core }) => {
const pr = context.payload.pull_request;
const hasApproved = pr.labels.some(l => l.name === approvedLabel);
if (!hasApproved) return setResult('noop');
// If a core/lead maintainer applied the label directly (not the bot via
// /lgtm), treat it as a sticky governance decision rather than a per-SHA
// approval. Check the union of always-allow + force-allow teams so lead
// maintainers are covered even when always-allow-teams is narrower.
const labeler = await lastLabeledBy(pr.number, approvedLabel);
if (labeler && labeler.type !== 'Bot') {
for (const team of [...alwaysAllowTeams, ...forceAllowTeams]) {
if (await isTeamMember(labeler.login, team)) {
core.info(`'${approvedLabel}' was applied manually by @${labeler.login} (member of @${owner}/${team}); skipping push invalidation.`);
return setResult('invalidate-skipped', labeler.login);
}
}
}
await removeLabel(pr.number, approvedLabel);
await dismissBotApprovals(pr.number, 'New commits pushed — approval invalidated.');
await disableAutoMerge(pr.node_id);