slash-commands: collapse github-token and bot-token into one input
The two-token split existed because the old design used GITHUB_TOKEN for user-visible writes (so they show as github-actions[bot]) and a separate PAT with read:org for the team check. With the GitHub App flow, one App installation token covers both roles. - Drop the bot-token input; github-token now handles all API calls - Replace the raw-fetch team check with github.rest.teams.getMembershipForUserInOrg — the main Octokit client is now authed with the same token - Remove the ORG_TOKEN env plumbing and the explanatory comment about why we couldn't use Octokit before
This commit is contained in:
parent
63db292169
commit
e518d5be36
1 changed files with 24 additions and 53 deletions
|
|
@ -9,21 +9,13 @@ description: >-
|
|||
inputs:
|
||||
github-token:
|
||||
description: >-
|
||||
Token used for org team-membership checks only. MUST have read:org
|
||||
scope — the default GITHUB_TOKEN cannot do this. Use a fine-grained PAT
|
||||
with Organization Members:read, or a GitHub App installation token with
|
||||
the same.
|
||||
GitHub App installation token used for all API calls: team-membership
|
||||
checks, labels, comments, reactions, reviews, auto-merge, CODEOWNERS
|
||||
fetch, and workflow dispatch. Must have Organization Members:read plus
|
||||
Repository Pull requests:write and Contents:read (and Actions:write if
|
||||
/stageblog is enabled). The default GITHUB_TOKEN will NOT work — it
|
||||
lacks read:org and its approvals may not count toward required reviews.
|
||||
required: true
|
||||
bot-token:
|
||||
description: >-
|
||||
Token used for all repo API calls: comments, reactions, labels, reviews,
|
||||
CODEOWNERS fetch, listFiles, and workflow dispatch. Defaults to the
|
||||
automatic GITHUB_TOKEN so user-visible side effects show as authored by
|
||||
github-actions[bot]. The caller workflow must grant this token the
|
||||
necessary permissions (pull-requests: write, issues: write,
|
||||
contents: read; plus actions: write for /stageblog).
|
||||
required: false
|
||||
default: ${{ github.token }}
|
||||
approved-label:
|
||||
description: Label added by /lgtm to mark the PR as accepted
|
||||
required: false
|
||||
|
|
@ -118,9 +110,8 @@ runs:
|
|||
AUTO_MERGE_METHOD: ${{ inputs.auto-merge-method }}
|
||||
STAGEBLOG_WORKFLOW: ${{ inputs.stageblog-workflow }}
|
||||
STAGEBLOG_PATHS: ${{ inputs.stageblog-paths }}
|
||||
ORG_TOKEN: ${{ inputs.github-token }}
|
||||
with:
|
||||
github-token: ${{ inputs.bot-token }}
|
||||
github-token: ${{ inputs.github-token }}
|
||||
script: |
|
||||
const main = require(process.env.GITHUB_ACTION_PATH + '/main.js');
|
||||
await main({ github, context, core });
|
||||
|
|
|
|||
Loading…
Reference in a new issue