modelcontextprotocol/conformance
Watch
1
0
Fork
You've already forked conformance
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(everything-server): send sampling/elicitation requests via extra.sendRequest (#414)

Browse source 
Tool handlers issued sampling/createMessage and elicitation/create via
mcpServer.server.request(), which carries no relatedRequestId. The SDK's
Streamable HTTP transport routes such requests to the standalone GET SSE
stream; if the client hasn't opened it yet, the request is silently parked
in the event store and the scenario times out after 60s.

Switch test_sampling, test_elicitation, test_elicitation_sep1034_defaults,
and test_elicitation_sep1330_enums to the handler's extra.sendRequest(),
which sets relatedRequestId so the request rides the originating tools/call
POST SSE stream.

Fixes #407


Claude-Session: https://claude.ai/code/session_01Qz5WunPTnDHVot4C2J6sFz

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
claude[bot] 2026-07-27 12:00:07 +01:00 • committed by GitHub
commit 31119a05f0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
examples/servers/typescript/everything-server.ts
View file

@ -539,10 +539,10 @@ function createMcpServer() {
prompt: z.string().describe('The prompt to send to the LLM')
}
},
async (args: { prompt: string }) => {
async (args: { prompt: string }, { sendRequest }) => {
try {
// Request sampling from client
const result = await mcpServer.server.request(
// Request sampling from client on the tool call's stream
const result = await sendRequest(
{
method: 'sampling/createMessage',
params: {
@ -599,10 +599,10 @@ function createMcpServer() {
message: z.string().describe('The message to show the user')
}
},
async (args: { message: string }) => {
async (args: { message: string }, { sendRequest }) => {
try {
// Request user input from client
const result = await mcpServer.server.request(
// Request user input from client on the tool call's stream
const result = await sendRequest(
{
method: 'elicitation/create',
params: {
@ -651,10 +651,10 @@ function createMcpServer() {
description: 'Tests elicitation with default values per SEP-1034',
inputSchema: {}
},
async () => {
async (_args, { sendRequest }) => {
try {
// Request user input with default values for all primitive types
const result = await mcpServer.server.request(
const result = await sendRequest(
{
method: 'elicitation/create',
params: {
@ -726,10 +726,10 @@ function createMcpServer() {
'Tests elicitation with enum schema improvements per SEP-1330',
inputSchema: {}
},
async () => {
async (_args, { sendRequest }) => {
try {
// Request user input with all 5 enum schema variants
const result = await mcpServer.server.request(
const result = await sendRequest(
{
method: 'elicitation/create',
params: {