modelcontextprotocol/conformance
Watch
1
0
Fork
You've already forked conformance
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(sep-2243): collapse check IDs to one-per-requirement (#287)

Browse source 
The sep-2243 scenario check IDs drifted from the requirement-traceability
yaml in #259 — the code emitted one ID per test case while the yaml
declares one per normative requirement, so the IDs no longer matched.

Rename the emitted IDs so a check ID maps to a single MUST/SHOULD and is
emitted once per case (the per-case detail moves to name/description),
matching the repo's existing 'same id, vary status/message' convention:

- mcp-method-header-* / mcp-name-header-*  -> client-includes-standard-headers
- reject-invalid-tool-* / keep-valid-tool  -> client-reject-invalid-tool
- server-accepts-{lower,upper}case-name    -> header-name-case-insensitive
- server reject status checks (mismatch/missing/case x method/name)
                                            -> server-reject-invalid-headers
- their error-code variants                 -> server-reject-error-code

Merge the yaml's server-reject-mismatch + server-reject-status into one
server-reject-invalid-headers MUST (HTTP 400 on a header-validation
failure); keep server-reject-error-code as the SHOULD. Base64/custom-header
rejection checks keep their own param-validation IDs (out of scope here).

Gates and the whitespace-acceptance check keep their scenario-matching
names. No behavior change — only check IDs, descriptions, and the yaml.
This commit is contained in:
Paul Carleton 2026-05-19 21:48:31 +01:00 • committed by GitHub
commit 70f7ba0004
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 48 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/scenarios/client/http-standard-headers.test.ts
View file

@ -31,14 +31,19 @@ describe('HttpStandardHeadersScenario (SEP-2243) — negative', () => {
});
}
it('FAILs sep-2243-mcp-method-header-initialize when Mcp-Method is missing', async () => {
// The coarse check id is emitted once per method/name case, so we narrow to
// the initialize Mcp-Method emission via its (case-specific) name.
const COARSE_ID = 'sep-2243-client-includes-standard-headers';
const INIT_METHOD_NAME = 'ClientMcpMethodHeader_initialize';
it('FAILs the initialize Mcp-Method emission when Mcp-Method is missing', async () => {
const scenario = new HttpStandardHeadersScenario();
const { serverUrl } = await scenario.start();
try {
await postInitialize(serverUrl, {}); // no Mcp-Method header
const checks = scenario.getChecks();
const check = checks.find(
(c) => c.id === 'sep-2243-mcp-method-header-initialize'
(c) => c.id === COARSE_ID && c.name === INIT_METHOD_NAME
);
expect(check?.status).toBe('FAILURE');
} finally {
@ -46,14 +51,14 @@ describe('HttpStandardHeadersScenario (SEP-2243) — negative', () => {
}
});
it('SUCCEEDs sep-2243-mcp-method-header-initialize when Mcp-Method matches', async () => {
it('SUCCEEDs the initialize Mcp-Method emission when Mcp-Method matches', async () => {
const scenario = new HttpStandardHeadersScenario();
const { serverUrl } = await scenario.start();
try {
await postInitialize(serverUrl, { 'Mcp-Method': 'initialize' });
const checks = scenario.getChecks();
const check = checks.find(
(c) => c.id === 'sep-2243-mcp-method-header-initialize'
(c) => c.id === COARSE_ID && c.name === INIT_METHOD_NAME
);
expect(check?.status).toBe('SUCCESS');
} finally {