modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Speed up CLI argument escaping tests (#1773)

Browse source 
Copilot-Session: 323a2062-9493-4be4-a710-f6c2b9e15a49
This commit is contained in:
Pranav Senthilnathan 2026-07-29 14:46:35 -07:00 • committed by GitHub
commit 155f619441
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 34 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

39
tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs
View file

@ -152,7 +152,9 @@ public class StdioClientTransportTests(ITestOutputHelper testOutputHelper) : Log
{
Assert.Skip("mono runtime does not handle arguments ending with backslash correctly.");
}
const string OutputPrefix = "CLI_ARG:";
var capturedArgument = new TaskCompletionSource<string>(TaskCreationOptions.RunContinuationsAsynchronously);
string cliArgument = $"--cli-arg={cliArgumentValue}";
string testServerExecutable = Path.Combine(AppContext.BaseDirectory, "TestServer.exe");
string testServerDll = Path.Combine(AppContext.BaseDirectory, "TestServer.dll");
@ -168,25 +170,34 @@ public class StdioClientTransportTests(ITestOutputHelper testOutputHelper) : Log
},
Arguments = (PlatformDetection.IsMonoRuntime, PlatformDetection.IsWindows) switch
{
(true, _) => [testServerExecutable, cliArgument],
(_, true) => [cliArgument],
_ => [testServerDll, cliArgument],
(true, _) => [testServerExecutable, "--echo-cli-arg-and-exit", cliArgument],
(_, true) => ["--echo-cli-arg-and-exit", cliArgument],
_ => [testServerDll, "--echo-cli-arg-and-exit", cliArgument],
},
StandardErrorLines = line =>
{
if (line.StartsWith(OutputPrefix, StringComparison.Ordinal))
{
capturedArgument.TrySetResult(line[OutputPrefix.Length..]);
}
},
};
var transport = new StdioClientTransport(options, LoggerFactory);
await using var session = await transport.ConnectAsync(TestContext.Current.CancellationToken);
// Act: Create client (handshake) and list tools to ensure full round trip works with the argument present.
await using var client = await McpClient.CreateAsync(transport, loggerFactory: LoggerFactory, cancellationToken: TestContext.Current.CancellationToken);
var tools = await client.ListToolsAsync(cancellationToken: TestContext.Current.CancellationToken);
string serializedArgument = await capturedArgument.Task.WaitAsync(
TestConstants.DefaultTimeout,
TestContext.Current.CancellationToken);
JsonElement parsedArgument = JsonElement.Parse(serializedArgument);
Assert.Equal(cliArgumentValue ?? "", parsedArgument.GetString());
// Assert
Assert.NotNull(tools);
Assert.NotEmpty(tools);
var result = await client.CallToolAsync("echoCliArg", cancellationToken: TestContext.Current.CancellationToken);
var content = Assert.IsType<TextContentBlock>(Assert.Single(result.Content));
Assert.Equal(cliArgumentValue ?? "", content.Text);
var exception = await Assert.ThrowsAsync<ClientTransportClosedException>(
async () => await session.MessageReader.Completion.WaitAsync(
TestConstants.DefaultTimeout,
TestContext.Current.CancellationToken));
var completionDetails = Assert.IsType<StdioClientCompletionDetails>(exception.Details);
Assert.Equal(0, completionDetails.ExitCode);
}
[Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))]