modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix stderr event loss due to missing WaitForExit in DisposeProcess (#1280)

Browse source 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
This commit is contained in:
Copilot 2026-02-15 16:33:09 -05:00 • committed by GitHub
commit 1dd06e73dc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/ModelContextProtocol.Core/Client/StdioClientTransport.cs
View file

@ -227,6 +227,18 @@ public sealed partial class StdioClientTransport : IClientTransport
// and Node.js does not kill its children when it exits properly. // and Node.js does not kill its children when it exits properly.
process.KillTree(shutdownTimeout); process.KillTree(shutdownTimeout);
} }
// Ensure all redirected stderr/stdout events have been dispatched
// before disposing. Only the no-arg WaitForExit() guarantees this;
// WaitForExit(int) (as used by KillTree) does not.
// This should not hang: either the process already exited on its own
// (no child processes holding handles), or KillTree killed the entire
// process tree. If it does take too long, the test infrastructure's
// own timeout will catch it.
if (!processRunning && HasExited(process))
{
process.WaitForExit();
}
} }
finally finally
{ {