From 283caf9810c42522daf5f2ad5053653ecba5d24b Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Fri, 30 Jan 2026 15:21:28 -0500 Subject: [PATCH] Fix race condition in AutomaticInputRequiredStatusTests polling logic (#1223) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> --- .../Server/AutomaticInputRequiredStatusTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ModelContextProtocol.Tests/Server/AutomaticInputRequiredStatusTests.cs b/tests/ModelContextProtocol.Tests/Server/AutomaticInputRequiredStatusTests.cs index 788e56c..1f5c51c 100644 --- a/tests/ModelContextProtocol.Tests/Server/AutomaticInputRequiredStatusTests.cs +++ b/tests/ModelContextProtocol.Tests/Server/AutomaticInputRequiredStatusTests.cs @@ -119,7 +119,7 @@ public class AutomaticInputRequiredStatusTests : LoggedTest finalStatus = await taskStore.GetTaskAsync(mcpTask.TaskId, cancellationToken: TestContext.Current.CancellationToken); maxAttempts--; } - while (finalStatus?.Status == McpTaskStatus.Working && maxAttempts > 0); + while (finalStatus?.Status is not McpTaskStatus.Completed && maxAttempts > 0); // Assert - Status should have been InputRequired during sampling Assert.Contains(McpTaskStatus.InputRequired, statusesDuringSampling); @@ -218,7 +218,7 @@ public class AutomaticInputRequiredStatusTests : LoggedTest finalStatus = await taskStore.GetTaskAsync(mcpTask.TaskId, cancellationToken: TestContext.Current.CancellationToken); maxAttempts--; } - while (finalStatus?.Status == McpTaskStatus.Working && maxAttempts > 0); + while (finalStatus?.Status is not McpTaskStatus.Completed && maxAttempts > 0); // Assert - Status should have been InputRequired during elicitation Assert.Contains(McpTaskStatus.InputRequired, statusesDuringElicitation);