modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Relax legacy request metadata validation (#1852)

Browse source 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Tarek Mahmoud Sayed <10833894+tarekgh@users.noreply.github.com>
This commit is contained in:
Stephen Halter 2026-09-13 16:30:42 -07:00 • committed by GitHub
commit 324ccd83c3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 780 additions and 391 deletions
Download patch file Download diff file Expand all files Collapse all files

51
tests/ModelContextProtocol.Tests/Client/McpClientMetaTests.cs
View file

@ -137,6 +137,53 @@ public class McpClientMetaTests : ClientServerTestBase
Assert.Contains("bar baz", textContent.Text);
}
[Fact]
public async Task LegacyToolCall_WithPerRequestClientMetadata_PreservesInitializedSessionState()
{
Server.ServerOptions.ToolCollection?.Add(McpServerTool.Create(
(RequestContext<CallToolRequestParams> context) =>
{
Assert.Null(context.JsonRpcRequest.Context?.ClientInfo);
Assert.Null(context.JsonRpcRequest.Context?.ClientCapabilities);
Assert.Equal("initialized-client", context.Server.ClientInfo?.Name);
Assert.NotNull(context.Server.ClientCapabilities?.Elicitation);
Assert.Null(context.Server.ClientCapabilities?.Sampling);
return "ok";
},
new() { Name = "legacy_meta_tool" }));
var clientOptions = new McpClientOptions
{
ProtocolVersion = LatestStableVersion,
ClientInfo = new Implementation { Name = "initialized-client", Version = "1.0.0" },
Handlers = new McpClientHandlers
{
ElicitationHandler = (_, _) => new ValueTask<ElicitResult>(new ElicitResult()),
},
};
await using McpClient client = await CreateMcpClientForServer(clientOptions);
var result = await client.CallToolAsync(
new CallToolRequestParams
{
Name = "legacy_meta_tool",
Meta = new JsonObject
{
[MetaKeys.ClientInfo] = JsonSerializer.SerializeToNode(
new Implementation { Name = "request-client", Version = "2.0.0" },
McpJsonUtilities.DefaultOptions),
[MetaKeys.ClientCapabilities] = JsonSerializer.SerializeToNode(
new ClientCapabilities { Sampling = new SamplingCapability() },
McpJsonUtilities.DefaultOptions),
},
},
TestContext.Current.CancellationToken);
Assert.Equal("ok", Assert.IsType<TextContentBlock>(Assert.Single(result.Content)).Text);
}
[Fact]
public async Task ConcurrentToolCalls_WithPerRequestClientCapabilities_UseRequestScopedCapabilities()
{
@ -250,9 +297,9 @@ public class McpClientMetaTests : ClientServerTestBase
ClientCapabilities? handlerObservedCapabilities = null;
Server.ServerOptions.ToolCollection?.Add(McpServerTool.Create(
(RequestContext<CallToolRequestParams> context) =>
(McpServer server) =>
{
handlerObservedCapabilities = context.Server.ClientCapabilities;
handlerObservedCapabilities = server.ClientCapabilities;
return "ok";
},
new() { Name = "capability_probe_tool" }));