modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Fix flaky stderr test: call WaitForExit() after WaitForExitAsync() to flush ErrorDataReceived events (#1278)

Browse source 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
This commit is contained in:
Copilot 2026-02-15 09:55:24 -05:00 • committed by GitHub
commit 3caac28a76
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/ModelContextProtocol.Core/Client/StdioClientSessionTransport.cs
View file

@ -72,11 +72,13 @@ internal sealed class StdioClientSessionTransport(
try try
{ {
// The process has exited, but we still need to ensure stderr has been flushed. // The process has exited, but we still need to ensure stderr has been flushed.
// WaitForExitAsync only waits for exit; it does not guarantee that all
// ErrorDataReceived events have been dispatched. The synchronous WaitForExit()
// (no arguments) does ensure that, so call it after WaitForExitAsync completes.
#if NET #if NET
await _process.WaitForExitAsync(cancellationToken).ConfigureAwait(false); await _process.WaitForExitAsync(cancellationToken).ConfigureAwait(false);
#else
_process.WaitForExit();
#endif #endif
_process.WaitForExit();
} }
catch { } catch { }