From 3f39ba793679ffeba344ae0086382cd0e85bd12a Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Wed, 19 Nov 2025 22:34:06 -0500 Subject: [PATCH] Skip flaky test on Mono where stderr callbacks are unsupported (#980) * Initial plan * Fix race condition in StdioClientSessionTransport stderr handling Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> * Simplify WaitForExit logic as suggested in code review Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> * Skip flaky test on Mono and revert incorrect fix Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> --- .../Transport/StdioClientTransportTests.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs b/tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs index 5394ba3..7f9cd61 100644 --- a/tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs +++ b/tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs @@ -22,8 +22,7 @@ public class StdioClientTransportTests(ITestOutputHelper testOutputHelper) : Log await Assert.ThrowsAsync(() => McpClient.CreateAsync(transport, loggerFactory: LoggerFactory, cancellationToken: TestContext.Current.CancellationToken)); } - // [Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))] - [Fact] + [Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))] public async Task CreateAsync_ValidProcessInvalidServer_StdErrCallbackInvoked() { string id = Guid.NewGuid().ToString("N");