From 482e311a70c54c92118e275bce82a7820a4f827a Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Thu, 29 Jan 2026 17:20:52 -0500 Subject: [PATCH] Fix StdioServerTransportTests to use Debug logging level instead of Trace (#1209) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> --- .../Transport/StdioServerTransportTests.cs | 32 ++++++++++++------- 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/tests/ModelContextProtocol.Tests/Transport/StdioServerTransportTests.cs b/tests/ModelContextProtocol.Tests/Transport/StdioServerTransportTests.cs index 3f57566..54a1a96 100644 --- a/tests/ModelContextProtocol.Tests/Transport/StdioServerTransportTests.cs +++ b/tests/ModelContextProtocol.Tests/Transport/StdioServerTransportTests.cs @@ -22,14 +22,6 @@ public class StdioServerTransportTests : LoggedTest InitializationTimeout = TimeSpan.FromSeconds(10), ServerInstructions = "Test Instructions" }; - - // Override the LoggerFactory to use Trace level for testing Trace-level logging - LoggerFactory = Microsoft.Extensions.Logging.LoggerFactory.Create(builder => - { - builder.AddProvider(XunitLoggerProvider); - builder.AddProvider(MockLoggerProvider); - builder.SetMinimumLevel(LogLevel.Trace); - }); } [Fact(Skip="https://github.com/modelcontextprotocol/csharp-sdk/issues/143")] @@ -207,19 +199,27 @@ public class StdioServerTransportTests : LoggedTest public async Task SendMessageAsync_Should_Log_At_Trace_Level() { // Arrange + var mockLoggerProvider = new MockLoggerProvider(); + using var traceLoggerFactory = Microsoft.Extensions.Logging.LoggerFactory.Create(builder => + { + builder.AddProvider(XunitLoggerProvider); + builder.AddProvider(mockLoggerProvider); + builder.SetMinimumLevel(LogLevel.Trace); + }); + using var output = new MemoryStream(); await using var transport = new StreamServerTransport( new Pipe().Reader.AsStream(), output, - loggerFactory: LoggerFactory); + loggerFactory: traceLoggerFactory); // Act var message = new JsonRpcRequest { Method = "test", Id = new RequestId(44) }; await transport.SendMessageAsync(message, TestContext.Current.CancellationToken); // Assert - var traceLogMessages = MockLoggerProvider.LogMessages + var traceLogMessages = mockLoggerProvider.LogMessages .Where(x => x.LogLevel == LogLevel.Trace && x.Message.Contains("transport sending message")) .ToList(); @@ -231,6 +231,14 @@ public class StdioServerTransportTests : LoggedTest public async Task ReadMessagesAsync_Should_Log_Received_At_Trace_Level() { // Arrange + var mockLoggerProvider = new MockLoggerProvider(); + using var traceLoggerFactory = Microsoft.Extensions.Logging.LoggerFactory.Create(builder => + { + builder.AddProvider(XunitLoggerProvider); + builder.AddProvider(mockLoggerProvider); + builder.SetMinimumLevel(LogLevel.Trace); + }); + var message = new JsonRpcRequest { Method = "test", Id = new RequestId(99) }; var json = JsonSerializer.Serialize(message, McpJsonUtilities.DefaultOptions); @@ -240,7 +248,7 @@ public class StdioServerTransportTests : LoggedTest await using var transport = new StreamServerTransport( input, Stream.Null, - loggerFactory: LoggerFactory); + loggerFactory: traceLoggerFactory); // Act await pipe.Writer.WriteAsync(Encoding.UTF8.GetBytes($"{json}\n"), TestContext.Current.CancellationToken); @@ -250,7 +258,7 @@ public class StdioServerTransportTests : LoggedTest Assert.True(canRead, "Nothing to read here from transport message reader"); // Assert - var traceLogMessages = MockLoggerProvider.LogMessages + var traceLogMessages = mockLoggerProvider.LogMessages .Where(x => x.LogLevel == LogLevel.Trace && x.Message.Contains("transport received message")) .ToList();