modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Include response body in HttpRequestException for transport client errors (#1193)

Browse source 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
This commit is contained in:
Copilot 2026-01-29 17:23:21 -05:00 • committed by GitHub
commit 7c85ac6706
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 149 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

73
tests/ModelContextProtocol.Tests/Transport/HttpClientTransportTests.cs
View file

@ -82,6 +82,32 @@ public class HttpClientTransportTests : LoggedTest
Assert.Equal(1, retries);
}
[Fact]
public async Task ConnectAsync_Throws_HttpRequestException_With_ResponseBody_On_ErrorStatusCode()
{
using var mockHttpHandler = new MockHttpHandler();
using var httpClient = new HttpClient(mockHttpHandler);
await using var transport = new HttpClientTransport(_transportOptions, httpClient, LoggerFactory);
const string errorDetails = "Bad request: Invalid MCP protocol version";
mockHttpHandler.RequestHandler = (request) =>
{
return Task.FromResult(new HttpResponseMessage
{
StatusCode = HttpStatusCode.BadRequest,
ReasonPhrase = "Bad Request",
Content = new StringContent(errorDetails)
});
};
var httpException = await Assert.ThrowsAsync<HttpRequestException>(() => transport.ConnectAsync(TestContext.Current.CancellationToken));
Assert.Contains(errorDetails, httpException.Message);
Assert.Contains("400", httpException.Message);
#if NET
Assert.Equal(HttpStatusCode.BadRequest, httpException.StatusCode);
#endif
}
[Fact]
public async Task SendMessageAsync_Handles_Accepted_Response()
{
@ -120,6 +146,53 @@ public class HttpClientTransportTests : LoggedTest
Assert.True(true);
}
[Fact]
public async Task SendMessageAsync_Throws_HttpRequestException_With_ResponseBody_On_ErrorStatusCode()
{
using var mockHttpHandler = new MockHttpHandler();
using var httpClient = new HttpClient(mockHttpHandler);
await using var transport = new HttpClientTransport(_transportOptions, httpClient, LoggerFactory);
var firstCall = true;
const string errorDetails = "Invalid JSON-RPC message format: missing 'id' field";
mockHttpHandler.RequestHandler = (request) =>
{
if (request.Method == HttpMethod.Post && request.RequestUri?.AbsoluteUri == "http://localhost:8080/sseendpoint")
{
return Task.FromResult(new HttpResponseMessage
{
StatusCode = HttpStatusCode.BadRequest,
ReasonPhrase = "Bad Request",
Content = new StringContent(errorDetails)
});
}
else
{
if (!firstCall)
throw new IOException("Abort");
else
firstCall = false;
return Task.FromResult(new HttpResponseMessage
{
StatusCode = HttpStatusCode.OK,
Content = new StringContent("event: endpoint\r\ndata: /sseendpoint\r\n\r\n")
});
}
};
await using var session = await transport.ConnectAsync(TestContext.Current.CancellationToken);
var httpException = await Assert.ThrowsAsync<HttpRequestException>(() =>
session.SendMessageAsync(new JsonRpcRequest { Method = RequestMethods.Initialize, Id = new RequestId(44) }, CancellationToken.None));
Assert.Contains(errorDetails, httpException.Message);
Assert.Contains("400", httpException.Message);
#if NET
Assert.Equal(HttpStatusCode.BadRequest, httpException.StatusCode);
#endif
}
[Fact]
public async Task ReceiveMessagesAsync_Handles_Messages()
{