modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Add 3-arg RequestContext constructor and obsolete 2-arg to eliminate null-forgiving operator usage (#1462)

Browse source
This commit is contained in:
Copilot 2026-03-27 12:33:23 -07:00 • committed by GitHub
commit 7dcdbafe9d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 190 additions and 219 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/ModelContextProtocol.Tests/Client/McpClientMetaTests.cs
View file

@ -37,7 +37,7 @@ public class McpClientMetaTests : ClientServerTestBase
async (RequestContext<CallToolRequestParams> context) =>
{
// Access the foo property of _meta field from the request parameters
var metaFoo = context.Params?.Meta?["foo"]?.ToString();
var metaFoo = context.Params.Meta?["foo"]?.ToString();
// Assert that the meta foo is correctly passed
Assert.NotNull(metaFoo);
@ -73,7 +73,7 @@ public class McpClientMetaTests : ClientServerTestBase
(RequestContext<ReadResourceRequestParams> context) =>
{
// Access the foo property of _meta field from the request parameters
var metaFoo = context.Params?.Meta?["foo"]?.ToString();
var metaFoo = context.Params.Meta?["foo"]?.ToString();
// Assert that the meta foo is correctly passed
Assert.NotNull(metaFoo);
@ -109,7 +109,7 @@ public class McpClientMetaTests : ClientServerTestBase
(RequestContext<GetPromptRequestParams> context) =>
{
// Access the foo property of _meta field from the request parameters
var metaFoo = context.Params?.Meta?["foo"]?.ToString();
var metaFoo = context.Params.Meta?["foo"]?.ToString();
// Assert that the meta foo is correctly passed
Assert.NotNull(metaFoo);

2
tests/ModelContextProtocol.Tests/Client/McpClientPromptTests.cs
View file

@ -29,7 +29,7 @@ public class McpClientPromptTests : ClientServerTestBase
[McpServerPrompt, Description("Echoes back the metadata it receives")]
public static ChatMessage MetadataEcho(RequestContext<GetPromptRequestParams> context) =>
new(ChatRole.User, context.Params?.Meta?.ToJsonString() ?? "{}");
new(ChatRole.User, context.Params.Meta?.ToJsonString() ?? "{}");
}
[Fact]

2
tests/ModelContextProtocol.Tests/Client/McpClientResourceTemplateConstructorTests.cs
View file

@ -27,7 +27,7 @@ public class McpClientResourceTemplateConstructorTests : ClientServerTestBase
[McpServerResource, Description("Echoes back the metadata it receives")]
public static string MetadataEcho(RequestContext<ReadResourceRequestParams> context, [Description("An ID")] string id) =>
context.Params?.Meta?.ToJsonString() ?? "{}";
context.Params.Meta?.ToJsonString() ?? "{}";
}
[Fact]

2
tests/ModelContextProtocol.Tests/Client/McpClientResourceTemplateTests.cs
View file

@ -17,7 +17,7 @@ public partial class McpClientResourceTemplateTests : ClientServerTestBase
mcpServerBuilder.WithReadResourceHandler((request, cancellationToken) =>
new ValueTask<ReadResourceResult>(new ReadResourceResult
{
Contents = [new TextResourceContents { Text = request.Params?.Uri ?? "", Uri = request.Params?.Uri ?? "" }]
Contents = [new TextResourceContents { Text = request.Params.Uri ?? "", Uri = request.Params.Uri ?? "" }]
}));
}

2
tests/ModelContextProtocol.Tests/Client/McpClientResourceTests.cs
View file

@ -27,7 +27,7 @@ public class McpClientResourceTests : ClientServerTestBase
[McpServerResource, Description("Echoes back the metadata it receives")]
public static string MetadataEcho(RequestContext<ReadResourceRequestParams> context) =>
context.Params?.Meta?.ToJsonString() ?? "{}";
context.Params.Meta?.ToJsonString() ?? "{}";
}
[Fact]

2
tests/ModelContextProtocol.Tests/Client/McpClientToolTests.cs
View file

@ -161,7 +161,7 @@ public class McpClientToolTests : ClientServerTestBase
[McpServerTool]
public static TextContentBlock MetadataEchoTool(RequestContext<CallToolRequestParams> context)
{
var meta = context.Params?.Meta;
var meta = context.Params.Meta;
var metaJson = meta?.ToJsonString() ?? "{}";
return new TextContentBlock { Text = metaJson };
}