modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Make Tool.Name required to match other protocol types (#1351)

Browse source 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
This commit is contained in:
Copilot 2026-02-23 11:33:01 -05:00 • committed by GitHub
commit 9b5d0fe80a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ModelContextProtocol.Core/Protocol/Tool.cs
View file

@ -15,7 +15,7 @@ public sealed class Tool : IBaseMetadata
{ {
/// <inheritdoc /> /// <inheritdoc />
[JsonPropertyName("name")] [JsonPropertyName("name")]
public string Name { get; set; } = string.Empty; public required string Name { get; set; }
/// <inheritdoc /> /// <inheritdoc />
[JsonPropertyName("title")] [JsonPropertyName("title")]

5
tests/ModelContextProtocol.Tests/Protocol/ToolTests.cs
View file

@ -95,7 +95,7 @@ public static class ToolTests
[Fact] [Fact]
public static void ToolInputSchema_HasValidDefaultSchema() public static void ToolInputSchema_HasValidDefaultSchema()
{ {
var tool = new Tool(); var tool = new Tool { Name = "test" };
JsonElement jsonElement = tool.InputSchema; JsonElement jsonElement = tool.InputSchema;
Assert.Equal(JsonValueKind.Object, jsonElement.ValueKind); Assert.Equal(JsonValueKind.Object, jsonElement.ValueKind);
@ -119,7 +119,7 @@ public static class ToolTests
public static void ToolInputSchema_RejectsInvalidSchemaDocuments(string invalidSchema) public static void ToolInputSchema_RejectsInvalidSchemaDocuments(string invalidSchema)
{ {
using var document = JsonDocument.Parse(invalidSchema); using var document = JsonDocument.Parse(invalidSchema);
var tool = new Tool(); var tool = new Tool { Name = "test" };
Assert.Throws<ArgumentException>(() => tool.InputSchema = document.RootElement); Assert.Throws<ArgumentException>(() => tool.InputSchema = document.RootElement);
} }
@ -133,6 +133,7 @@ public static class ToolTests
using var document = JsonDocument.Parse(validSchema); using var document = JsonDocument.Parse(validSchema);
Tool tool = new() Tool tool = new()
{ {
Name = "test",
InputSchema = document.RootElement InputSchema = document.RootElement
}; };