modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Adjust analyzer diagnostic severities and improve MCP001 reporting (#1038)

Browse source 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
This commit is contained in:
Copilot 2025-11-26 21:51:37 -05:00 • committed by GitHub
commit b230b17ec9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 17 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/ModelContextProtocol.Analyzers.Tests/XmlToDescriptionGeneratorTests.cs
View file

@ -381,7 +381,7 @@ public partial class XmlToDescriptionGeneratorTests
// Should report MCP002 diagnostic
var diagnostic = Assert.Single(result.Diagnostics, d => d.Id == "MCP002");
Assert.Equal(DiagnosticSeverity.Warning, diagnostic.Severity);
Assert.Equal(DiagnosticSeverity.Info, diagnostic.Severity);
Assert.Contains("TestMethod", diagnostic.GetMessage());
Assert.Contains("partial", diagnostic.GetMessage());
}
@ -412,7 +412,7 @@ public partial class XmlToDescriptionGeneratorTests
// Should report MCP002 diagnostic because parameter has documentation
var diagnostic = Assert.Single(result.Diagnostics, d => d.Id == "MCP002");
Assert.Equal(DiagnosticSeverity.Warning, diagnostic.Severity);
Assert.Equal(DiagnosticSeverity.Info, diagnostic.Severity);
}
[Fact]
@ -441,7 +441,7 @@ public partial class XmlToDescriptionGeneratorTests
// Should report MCP002 diagnostic because return has documentation
var diagnostic = Assert.Single(result.Diagnostics, d => d.Id == "MCP002");
Assert.Equal(DiagnosticSeverity.Warning, diagnostic.Severity);
Assert.Equal(DiagnosticSeverity.Info, diagnostic.Severity);
}
[Fact]
@ -559,7 +559,7 @@ public partial class XmlToDescriptionGeneratorTests
// Should report MCP002 diagnostic because parameter description would be generated
var diagnostic = Assert.Single(result.Diagnostics, d => d.Id == "MCP002");
Assert.Equal(DiagnosticSeverity.Warning, diagnostic.Severity);
Assert.Equal(DiagnosticSeverity.Info, diagnostic.Severity);
}
[Fact]
@ -590,7 +590,7 @@ public partial class XmlToDescriptionGeneratorTests
// Should report MCP002 diagnostic for prompts too
var diagnostic = Assert.Single(result.Diagnostics, d => d.Id == "MCP002");
Assert.Equal(DiagnosticSeverity.Warning, diagnostic.Severity);
Assert.Equal(DiagnosticSeverity.Info, diagnostic.Severity);
}
[Fact]
@ -621,7 +621,7 @@ public partial class XmlToDescriptionGeneratorTests
// Should report MCP002 diagnostic for resources too
var diagnostic = Assert.Single(result.Diagnostics, d => d.Id == "MCP002");
Assert.Equal(DiagnosticSeverity.Warning, diagnostic.Severity);
Assert.Equal(DiagnosticSeverity.Info, diagnostic.Severity);
}
[Fact]