From b9c0f269d6eb0ade3192f21d9243d9f8f82819be Mon Sep 17 00:00:00 2001 From: Jeff Handley Date: Wed, 9 Apr 2025 00:14:09 -0700 Subject: [PATCH] Update markdown-link-check to ignore external links causing 403 in CI (#246) * Update markdown-link-check to ignore external links causing 403 in CI * Apply wildcards on ignored links * Bump version of mlc to latest to gain --ignore-links arg * Do not warn on redirects from markdown-link-check action * Do not warn on redirects from markdown-link-check action * Update comment --- .github/workflows/markdown-link-check.yml | 6 +++++- .github/workflows/release.md | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index d3fdfea..3229db0 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -12,5 +12,9 @@ jobs: steps: - name: Checkout uses: actions/checkout@main + - name: Markup Link Checker (mlc) - uses: becheran/mlc@v0.15.4 \ No newline at end of file + uses: becheran/mlc@v0.21.0 + with: + # Ignore external links that result in 403 errors during CI. Do not warn for redirects where we want to keep the vanity URL in the markdown or for GitHub links that redirect to the login. + args: --ignore-links "https://www.anthropic.com/*,https://hackerone.com/anthropic-vdp/*" --do-not-warn-for-redirect-to "https://modelcontextprotocol.io/*,https://github.com/login?*" ./ diff --git a/.github/workflows/release.md b/.github/workflows/release.md index 4077944..834f56b 100644 --- a/.github/workflows/release.md +++ b/.github/workflows/release.md @@ -31,7 +31,7 @@ The following process is used when publishing new releases to NuGet.org: 3. **Monitor the Release workflow** - After publishing the release, a workflow will begin for producing the release's build artifacts and publishing the NuGet package to NuGet.org - If the job fails, troubleshoot and re-run the workflow as needed - - Verify the package version becomes listed on at [https://nuget.org/packages/ModelContextProtocol](https://nuget.org/packages/ModelContextProtocol) + - Verify the package version becomes listed on at [https://nuget.org/packages/ModelContextProtocol](https://www.nuget.org/packages/ModelContextProtocol) 4. **Update the source to increment the version number** - Immediately after publishing a new release, the [`/src/Directory.Build.Props`](../../src/Directory.Build.props) file needs to be updated to bump the version to the next expected release version