modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix StdioServerTransport.DisposeAsync hang (#235)

Browse source 
- It's not just Unix, it's all platforms that can hang
- Windows doesn't hang on Ctrl-C because that triggers
  the end of the Stream, but that doesn't help in IHostApplicationLifetime.StopAsync() scenarios

4e9627e311/src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs (L13)
4e9627e311/src/libraries/System.Console/src/System/ConsolePal.Windows.cs (L1149)
This commit is contained in:
Stephen Halter 2025-04-08 10:20:16 -07:00 • committed by GitHub
commit bab74d5895
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 114 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/ModelContextProtocol.Tests/Utils/KestrelInMemoryConnection.cs
View file

@ -8,8 +8,8 @@ public sealed class KestrelInMemoryConnection : ConnectionContext
{
private readonly Pipe _clientToServerPipe = new();
private readonly Pipe _serverToClientPipe = new();
private readonly CancellationTokenSource _connectionClosedCts = new CancellationTokenSource();
private readonly IFeatureCollection _features = new FeatureCollection();
private readonly CancellationTokenSource _connectionClosedCts = new();
private readonly FeatureCollection _features = new();
public KestrelInMemoryConnection()
{
@ -37,17 +37,17 @@ public sealed class KestrelInMemoryConnection : ConnectionContext
public override IDictionary<object, object?> Items { get; set; } = new Dictionary<object, object?>();
public override ValueTask DisposeAsync()
public override async ValueTask DisposeAsync()
{
// This is called by Kestrel. The client should dispose the DuplexStream which
// completes the other half of these pipes.
_serverToClientPipe.Writer.Complete();
_serverToClientPipe.Reader.Complete();
await _serverToClientPipe.Writer.CompleteAsync();
await _serverToClientPipe.Reader.CompleteAsync();
// Don't bother disposing the _connectionClosedCts, since this is just for testing,
// and it's annoying to synchronize with DuplexStream.
return base.DisposeAsync();
await base.DisposeAsync();
}
private class DuplexPipe : IDuplexPipe