From bd5aef6020782ab97e9b4e7340cf27281ae0cb78 Mon Sep 17 00:00:00 2001 From: Szymon Kulec Date: Fri, 18 Jul 2025 20:36:08 +0200 Subject: [PATCH] UnreferenceDisposable made slimmer (#627) --- src/ModelContextProtocol.AspNetCore/HttpMcpSession.cs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ModelContextProtocol.AspNetCore/HttpMcpSession.cs b/src/ModelContextProtocol.AspNetCore/HttpMcpSession.cs index c34aba6..1456ce5 100644 --- a/src/ModelContextProtocol.AspNetCore/HttpMcpSession.cs +++ b/src/ModelContextProtocol.AspNetCore/HttpMcpSession.cs @@ -25,13 +25,15 @@ internal sealed class HttpMcpSession( public bool IsActive => !SessionClosed.IsCancellationRequested && _referenceCount > 0; public long LastActivityTicks { get; private set; } = timeProvider.GetTimestamp(); + private TimeProvider TimeProvider => timeProvider; + public IMcpServer? Server { get; set; } public Task? ServerRunTask { get; set; } public IDisposable AcquireReference() { Interlocked.Increment(ref _referenceCount); - return new UnreferenceDisposable(this, timeProvider); + return new UnreferenceDisposable(this); } public bool TryStartGetRequest() => Interlocked.Exchange(ref _getRequestStarted, 1) == 0; @@ -70,13 +72,13 @@ internal sealed class HttpMcpSession( public bool HasSameUserId(ClaimsPrincipal user) => UserIdClaim == StreamableHttpHandler.GetUserIdClaim(user); - private sealed class UnreferenceDisposable(HttpMcpSession session, TimeProvider timeProvider) : IDisposable + private sealed class UnreferenceDisposable(HttpMcpSession session) : IDisposable { public void Dispose() { if (Interlocked.Decrement(ref session._referenceCount) == 0) { - session.LastActivityTicks = timeProvider.GetTimestamp(); + session.LastActivityTicks = session.TimeProvider.GetTimestamp(); } } }