modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix HandlesIProgressParameter test sporadically failing in CI (#327)

Browse source
This commit is contained in:
Stephen Toub 2025-04-18 12:23:19 -04:00 • committed by GitHub
commit d65ddce268
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/ModelContextProtocol.Tests/Configuration/McpServerBuilderExtensionsToolsTests.cs
View file

@ -596,11 +596,22 @@ public partial class McpServerBuilderExtensionsToolsTests : ClientServerTestBase
McpClientTool progressTool = tools.First(t => t.Name == nameof(EchoTool.SendsProgressNotifications)); McpClientTool progressTool = tools.First(t => t.Name == nameof(EchoTool.SendsProgressNotifications));
TaskCompletionSource tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
int remainingNotifications = 10;
ConcurrentQueue<ProgressNotification> notifications = new(); ConcurrentQueue<ProgressNotification> notifications = new();
await using (client.RegisterNotificationHandler(NotificationMethods.ProgressNotification, (notification, cancellationToken) => await using (client.RegisterNotificationHandler(NotificationMethods.ProgressNotification, (notification, cancellationToken) =>
{ {
ProgressNotification pn = JsonSerializer.Deserialize<ProgressNotification>(notification.Params, McpJsonUtilities.DefaultOptions)!; if (JsonSerializer.Deserialize<ProgressNotification>(notification.Params, McpJsonUtilities.DefaultOptions) is { } pn &&
notifications.Enqueue(pn); pn.ProgressToken == new ProgressToken("abc123"))
{
notifications.Enqueue(pn);
if (Interlocked.Decrement(ref remainingNotifications) == 0)
{
tcs.SetResult();
}
}
return default; return default;
})) }))
{ {
@ -613,8 +624,8 @@ public partial class McpServerBuilderExtensionsToolsTests : ClientServerTestBase
}, },
cancellationToken: TestContext.Current.CancellationToken); cancellationToken: TestContext.Current.CancellationToken);
await tcs.Task;
Assert.Contains("done", JsonSerializer.Serialize(result, McpJsonUtilities.DefaultOptions)); Assert.Contains("done", JsonSerializer.Serialize(result, McpJsonUtilities.DefaultOptions));
SpinWait.SpinUntil(() => notifications.Count == 10, TimeSpan.FromSeconds(10));
} }
ProgressNotification[] array = notifications.OrderBy(n => n.Progress.Progress).ToArray(); ProgressNotification[] array = notifications.OrderBy(n => n.Progress.Progress).ToArray();