feat: MCP app sampling support via stock SDK types (alt to #477) (#530)

* feat: MCP app sampling support via stock SDK types

Alternative to #477. Instead of forking a stripped-down sampling schema,
this reuses the stock `CreateMessageRequest` / `CreateMessageResult` /
`CreateMessageResultWithTools` types from `@modelcontextprotocol/sdk`
directly — same pattern already used for `tools/call`.

- Spec: `sampling/createMessage` listed under `### Standard MCP Messages`,
  `sampling?: { tools?: {} }` added to `HostCapabilities` (mirrors MCP
  `ClientCapabilities.sampling` shape for easy pass-through).
- SDK: `App.createSamplingMessage()` with overloads that narrow the return
  type based on whether `params.tools` is set; `AppBridge.oncreatesamplingmessage`
  setter; `CreateMessageRequest`/`CreateMessageResult*` added to the
  `AppRequest`/`AppResult` unions.
- Picks up SEP-1577 tool-calling support (`tools`, `toolChoice`, `tool_use`
  content blocks, `stopReason: "toolUse"`, array content) for free — unblocks
  the "nested agents" use case motivated by the original PR.

https://claude.ai/code/session_01ENGWTtsfcyP4S6fTWtUMAh

* feat(app): guard createSamplingMessage before handshake completes

---------

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Olivier Chafik 2026-04-21 13:29:09 +01:00 • committed by GitHub
commit 926dcb4fe9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 323 additions and 1 deletions

View file

@ -516,6 +516,10 @@ UI iframes can use the following subset of standard MCP protocol messages:
- `resources/read` - Read resource content
**Sampling:**
- `sampling/createMessage` - Request an LLM completion from the host (uses the standard MCP [`CreateMessageRequest`](https://modelcontextprotocol.io/specification/2025-11-25/client/sampling) / `CreateMessageResult` types, including SEP-1577 `tools` / `toolChoice` / `tool_use` content blocks). The host has full discretion over model selection and SHOULD apply rate limiting, cost controls, and user approval (human-in-the-loop). Apps MUST check `hostCapabilities.sampling` before sending this request, and `hostCapabilities.sampling.tools` before including `tools` in the request params.
**Notifications:**
- `notifications/message` - Log messages to host
@ -662,6 +666,14 @@ interface HostCapabilities {
};
/** Host accepts log messages. */
logging?: {};
/**
* Host supports LLM sampling (sampling/createMessage) from the view.
* Mirrors MCP ClientCapabilities.sampling so hosts can pass it through.
*/
sampling?: {
/** Host supports tool use via `tools` and `toolChoice` params (SEP-1577). */
tools?: {};
};
/** Sandbox configuration applied by the host. */
sandbox?: {
/** Permissions granted by the host (camera, microphone, geolocation, clipboard-write). */

View file

@ -12,6 +12,8 @@ import type { Transport } from "@modelcontextprotocol/sdk/shared/transport.js";
import {
CallToolResult,
CallToolResultSchema,
CreateMessageRequest,
CreateMessageResult,
ListResourcesResultSchema,
ReadResourceResultSchema,
ListPromptsResultSchema,
@ -228,6 +230,26 @@ function AppBridge_oncalltool_forwardToServer(
//#endregion AppBridge_oncalltool_forwardToServer
}
/**
* Example: Forward sampling requests to your LLM provider.
*/
function AppBridge_oncreatesamplingmessage_forwardToLlm(
bridge: AppBridge,
myLlmProvider: {
complete: (
params: CreateMessageRequest["params"],
opts: { signal: AbortSignal },
) => Promise<CreateMessageResult>;
},
) {
//#region AppBridge_oncreatesamplingmessage_forwardToLlm
bridge.oncreatesamplingmessage = async (params, extra) => {
// Apply rate limiting, user approval, cost controls here
return await myLlmProvider.complete(params, { signal: extra.signal });
};
//#endregion AppBridge_oncreatesamplingmessage_forwardToLlm
}
/**
* Example: Forward list resources requests to the MCP server.
*/

View file

@ -737,6 +737,43 @@ describe("App <-> AppBridge integration", () => {
expect(result.content).toEqual(resultContent);
});
it("oncreatesamplingmessage setter registers handler for sampling/createMessage requests", async () => {
// Re-create bridge with sampling capability so App's capability check passes
bridge = new AppBridge(null, testHostInfo, {
...testHostCapabilities,
sampling: { tools: {} },
});
const receivedParams: unknown[] = [];
bridge.oncreatesamplingmessage = async (params) => {
receivedParams.push(params);
return {
role: "assistant",
content: { type: "text", text: "Hello from the model" },
model: "test-model",
stopReason: "endTurn",
};
};
await bridge.connect(bridgeTransport);
await app.connect(appTransport);
expect(app.getHostCapabilities()?.sampling?.tools).toEqual({});
const result = await app.createSamplingMessage({
messages: [{ role: "user", content: { type: "text", text: "Hi" } }],
maxTokens: 50,
});
expect(receivedParams).toHaveLength(1);
expect(receivedParams[0]).toMatchObject({ maxTokens: 50 });
expect(result.model).toEqual("test-model");
expect(result.content).toEqual({
type: "text",
text: "Hello from the model",
});
});
it("ondownloadfile setter registers handler for ui/download-file requests", async () => {
const downloadParams = {
contents: [

View file

@ -5,6 +5,10 @@ import {
CallToolRequestSchema,
CallToolResult,
CallToolResultSchema,
CreateMessageRequest,
CreateMessageRequestSchema,
CreateMessageResult,
CreateMessageResultWithTools,
EmptyResult,
Implementation,
ListPromptsRequest,
@ -1049,6 +1053,49 @@ export class AppBridge extends ProtocolWithEvents<
);
}
/**
* Register a handler for LLM sampling requests from the view.
*
* The view sends standard MCP `sampling/createMessage` requests to obtain
* LLM completions via the host's model connection. The host has full
* discretion over which model to use and SHOULD apply rate limiting,
* cost controls, and user approval (human-in-the-loop) before sampling.
*
* Hosts that register this handler SHOULD advertise `sampling` (and
* `sampling.tools` if tool-calling is supported) in
* {@link McpUiHostCapabilities `McpUiHostCapabilities`}.
*
* @param callback - Handler that receives `CreateMessageRequest` params and
* returns a `CreateMessageResult` (or `CreateMessageResultWithTools` when
* `params.tools` was provided)
* - `params` - Standard MCP sampling params (messages, maxTokens, tools, etc.)
* - `extra` - Request metadata (abort signal, session info)
*
* @example Forward to your LLM provider
* ```ts source="./app-bridge.examples.ts#AppBridge_oncreatesamplingmessage_forwardToLlm"
* bridge.oncreatesamplingmessage = async (params, extra) => {
* // Apply rate limiting, user approval, cost controls here
* return await myLlmProvider.complete(params, { signal: extra.signal });
* };
* ```
*
* @see `CreateMessageRequest` from @modelcontextprotocol/sdk for the request type
* @see `CreateMessageResult` / `CreateMessageResultWithTools` from @modelcontextprotocol/sdk for result types
*/
set oncreatesamplingmessage(
callback: (
params: CreateMessageRequest["params"],
extra: RequestHandlerExtra,
) => Promise<CreateMessageResult | CreateMessageResultWithTools>,
) {
this.setRequestHandler(
CreateMessageRequestSchema,
async (request, extra) => {
return callback(request.params, extra);
},
);
}
/**
* Notify the view that the MCP server's tool list has changed.
*

View file

@ -334,6 +334,54 @@ async function App_callServerTool_fetchWeather(app: App) {
//#endregion App_callServerTool_fetchWeather
}
/**
* Example: Simple LLM completion via host sampling.
*/
async function App_createSamplingMessage_simple(app: App) {
//#region App_createSamplingMessage_simple
const result = await app.createSamplingMessage({
messages: [
{
role: "user",
content: { type: "text", text: "Summarize this in one line." },
},
],
maxTokens: 100,
});
console.log(result.content);
//#endregion App_createSamplingMessage_simple
}
/**
* Example: Agentic loop with tools (requires host sampling.tools capability).
*/
async function App_createSamplingMessage_withTools(
app: App,
messages: import("@modelcontextprotocol/sdk/types.js").SamplingMessage[],
) {
//#region App_createSamplingMessage_withTools
if (!app.getHostCapabilities()?.sampling?.tools) return;
const result = await app.createSamplingMessage({
messages,
maxTokens: 1024,
tools: [
{
name: "get_weather",
description: "Get the current weather",
inputSchema: {
type: "object",
properties: { city: { type: "string" } },
},
},
],
});
if (result.stopReason === "toolUse") {
// result.content may be an array containing tool_use blocks
}
//#endregion App_createSamplingMessage_withTools
}
/**
* Example: Read a video resource and play it.
*/

View file

@ -8,6 +8,11 @@ import {
CallToolRequestSchema,
CallToolResult,
CallToolResultSchema,
CreateMessageRequest,
CreateMessageResult,
CreateMessageResultSchema,
CreateMessageResultWithTools,
CreateMessageResultWithToolsSchema,
EmptyResultSchema,
Implementation,
ListResourcesRequest,
@ -802,7 +807,15 @@ export class App extends ProtocolWithEvents<
* @internal
*/
assertCapabilityForMethod(method: AppRequest["method"]): void {
// TODO
switch (method) {
case "sampling/createMessage":
if (!this._hostCapabilities?.sampling) {
throw new Error(
`Host does not support sampling (required for ${method})`,
);
}
break;
}
}
/**
@ -1011,6 +1024,90 @@ export class App extends ProtocolWithEvents<
);
}
/**
* Request an LLM completion from the host (standard MCP `sampling/createMessage`).
*
* Enables the app to use the host's model connection for completions. The host
* has full discretion over which model to select and MAY modify or reject the
* request (human-in-the-loop). Check {@link getHostCapabilities `getHostCapabilities`}`()?.sampling`
* before calling — hosts without this capability will reject the request.
*
* This method reuses the stock MCP `CreateMessageRequest` shape. When `params.tools`
* is provided, the result is parsed with the extended schema that permits
* `stopReason: "toolUse"` and array content containing `tool_use` blocks.
*
* @param params - Standard MCP `CreateMessageRequest` params (messages, maxTokens,
* systemPrompt, temperature, modelPreferences, tools, toolChoice, etc.)
* @param options - Request options (timeout, abort signal)
* @returns `CreateMessageResult` (single content block) or `CreateMessageResultWithTools`
* (array content, may include `tool_use` blocks) depending on whether `tools` was set
*
* @throws {Error} If the host rejects the request or does not support sampling
* @throws {Error} If the request times out or the connection is lost
*
* @example Simple completion
* ```ts source="./app.examples.ts#App_createSamplingMessage_simple"
* const result = await app.createSamplingMessage({
* messages: [
* {
* role: "user",
* content: { type: "text", text: "Summarize this in one line." },
* },
* ],
* maxTokens: 100,
* });
* console.log(result.content);
* ```
*
* @example Agentic loop with tools
* ```ts source="./app.examples.ts#App_createSamplingMessage_withTools"
* if (!app.getHostCapabilities()?.sampling?.tools) return;
*
* const result = await app.createSamplingMessage({
* messages,
* maxTokens: 1024,
* tools: [
* {
* name: "get_weather",
* description: "Get the current weather",
* inputSchema: {
* type: "object",
* properties: { city: { type: "string" } },
* },
* },
* ],
* });
* if (result.stopReason === "toolUse") {
* // result.content may be an array containing tool_use blocks
* }
* ```
*
* @see `CreateMessageRequest` from @modelcontextprotocol/sdk for the request type
* @see `CreateMessageResult` / `CreateMessageResultWithTools` from @modelcontextprotocol/sdk for result types
*/
async createSamplingMessage(
params: CreateMessageRequest["params"] & { tools?: undefined },
options?: RequestOptions,
): Promise<CreateMessageResult>;
async createSamplingMessage(
params: CreateMessageRequest["params"],
options?: RequestOptions,
): Promise<CreateMessageResultWithTools>;
async createSamplingMessage(
params: CreateMessageRequest["params"],
options?: RequestOptions,
): Promise<CreateMessageResult | CreateMessageResultWithTools> {
this._assertInitialized("createSamplingMessage");
const resultSchema = params.tools
? CreateMessageResultWithToolsSchema
: CreateMessageResultSchema;
return await this.request(
{ method: "sampling/createMessage", params },
resultSchema,
options,
);
}
/**
* Send a message to the host's chat interface.
*

View file

@ -501,6 +501,19 @@
}
},
"additionalProperties": false
},
"sampling": {
"description": "Host supports LLM sampling (sampling/createMessage) from the view.\nMirrors the MCP `ClientCapabilities.sampling` shape so hosts can pass it through.",
"type": "object",
"properties": {
"tools": {
"description": "Host supports tool use via `tools` and `toolChoice` parameters.",
"type": "object",
"properties": {},
"additionalProperties": false
}
},
"additionalProperties": false
}
},
"additionalProperties": false
@ -2841,6 +2854,19 @@
}
},
"additionalProperties": false
},
"sampling": {
"description": "Host supports LLM sampling (sampling/createMessage) from the view.\nMirrors the MCP `ClientCapabilities.sampling` shape so hosts can pass it through.",
"type": "object",
"properties": {
"tools": {
"description": "Host supports tool use via `tools` and `toolChoice` parameters.",
"type": "object",
"properties": {},
"additionalProperties": false
}
},
"additionalProperties": false
}
},
"additionalProperties": false,

View file

@ -558,6 +558,24 @@ export const McpUiHostCapabilitiesSchema = z.object({
message: McpUiSupportedContentBlockModalitiesSchema.optional().describe(
"Host supports receiving content messages (ui/message) from the view.",
),
/**
* @description Host supports LLM sampling (sampling/createMessage) from the view.
* Mirrors the MCP `ClientCapabilities.sampling` shape so hosts can pass it through.
*/
sampling: z
.object({
/** @description Host supports tool use via `tools` and `toolChoice` parameters. */
tools: z
.object({})
.optional()
.describe(
"Host supports tool use via `tools` and `toolChoice` parameters.",
),
})
.optional()
.describe(
"Host supports LLM sampling (sampling/createMessage) from the view.\nMirrors the MCP `ClientCapabilities.sampling` shape so hosts can pass it through.",
),
});
/**

View file

@ -521,6 +521,14 @@ export interface McpUiHostCapabilities {
updateModelContext?: McpUiSupportedContentBlockModalities;
/** @description Host supports receiving content messages (ui/message) from the view. */
message?: McpUiSupportedContentBlockModalities;
/**
* @description Host supports LLM sampling (sampling/createMessage) from the view.
* Mirrors the MCP `ClientCapabilities.sampling` shape so hosts can pass it through.
*/
sampling?: {
/** @description Host supports tool use via `tools` and `toolChoice` parameters. */
tools?: {};
};
}
/**

View file

@ -140,6 +140,9 @@ export {
import {
CallToolRequest,
CallToolResult,
CreateMessageRequest,
CreateMessageResult,
CreateMessageResultWithTools,
EmptyResult,
ListPromptsRequest,
ListPromptsResult,
@ -165,6 +168,7 @@ import {
* - MCP UI requests (initialize, open-link, message, resource-teardown, request-display-mode)
* - MCP server requests forwarded from the app (tools/call, tools/list, resources/list,
* resources/templates/list, resources/read, prompts/list)
* - MCP client requests forwarded to the host (sampling/createMessage)
* - Protocol requests (ping)
*/
export type AppRequest =
@ -181,6 +185,7 @@ export type AppRequest =
| ListResourceTemplatesRequest
| ReadResourceRequest
| ListPromptsRequest
| CreateMessageRequest
| PingRequest;
/**
@ -230,4 +235,6 @@ export type AppResult =
| ListResourceTemplatesResult
| ReadResourceResult
| ListPromptsResult
| CreateMessageResult
| CreateMessageResultWithTools
| EmptyResult;