* fix(pdf-server): translucent highlights, pinch to/from fullscreen, toolbar layout Highlights rendered opaque: inline `background: <hex>` overrode the CSS rgba(...,0.35). Now convert def.color via cssColorToRgb and force alpha 0.35. Added a toHaveCSS regression check in pdf-annotations.spec.ts. Pinch-in while inline (wheel ctrlKey deltaY<0 or two-finger spread >1.15x) now enters fullscreen. Pinch-out in fullscreen past 0.9x of fit-scale, when already at/below fit, exits to inline and clears userHasZoomed so refit sizes the inline view. previewScaleRaw tracks the unclamped intent so the exit fires even when fit ~= ZOOM_MIN. A modeTransitionInFlight latch (held 250ms post-toggle) keeps the gesture tail from re-toggling or immediately zooming the new view. Fullscreen toolbar: flex-wrap: nowrap and tighter 0.25rem vertical padding (min-height 40px + safe-top instead of 48px + wrap). Search bar top/right now follow --safe-top/--safe-right so it sits flush below the toolbar instead of overlapping it. Base .canvas-container gets touch-action: pan-x pan-y so the inline pinch is capturable on iOS. * fix(pdf-server): drop --safe-top from fullscreen toolbar padding Hosts wrap fullscreen in their own header (title + close), which already clears the top safe-area. Adding --safe-top to our toolbar padding-top double-dipped, leaving a visible gap between the host header and our toolbar. Keep --safe-left/right (host header doesn't cover the sides). * feat(pdf-server): horizontal swipe changes pages whenever page fits width Previously gated on scale <= 1.0, which blocked page-nav in fullscreen where fit-scale is often >100%. Now gate on actual horizontal overflow (scrollWidth > clientWidth) so swipe works at any fit-to-width scale and still defers to native panning once you zoom past it. * fix(pdf-server): refit to inline width after pinch-out exits fullscreen handleHostContextChanged calls refitScale() before the iframe has actually shrunk, and the ResizeObserver's inline branch only refits on width *growth* (to avoid a requestFitToContent shrink-loop). So the fullscreen->inline shrink never triggered a refit and the page stayed at the fullscreen scale. Add a one-shot forceNextResizeRefit flag, set on fullscreen->inline (both the pinch-out path and handleHostContextChanged), consumed by the ResizeObserver on the next size change. One-shot keeps the shrink-loop guard intact for ordinary inline resizes. * feat(pdf-server): floor fullscreen zoom at fit-to-page In fullscreen, pinch-out and the zoom-out button now floor at the fit-to-page scale instead of ZOOM_MIN, so the page never shrinks below fully-visible (no dead margin around it). previewScaleRaw stays unclamped so a continued pinch-out past fit still triggers exit-to-inline. * fix(pdf-server): wheel pinch-out can exit fullscreen again The fit-floor pinned previewScale at fit, but the wheel handler multiplied the *clamped* previewScale, so it could never accumulate below fit*0.9 to trigger exit. Drive the wheel accumulator off previewScaleRaw instead, and bound previewScaleRaw to [floor*0.7, ZOOM_MAX] so it can cross the 0.9 exit threshold without drifting unboundedly (which would make direction reversal feel sticky). Touch path was unaffected (absolute ratio). * fix(pdf-server): always refit to inline width on fullscreen exit userHasZoomed stayed true after Escape/button/host-× exits, so refitScale() bailed even though forceNextResizeRefit let the ResizeObserver call it. Clear userHasZoomed in handleHostContextChanged whenever we land inline — fullscreen zoom level is meaningless there. Dropped the now-dead requestFitToContent fallback in the same block. * refactor(pdf-server): rubber-band pinch-out instead of dual-tracked clamp The previewScaleRaw side-channel made the gesture feel dead (page pinned at fit, no feedback) and the wheel accumulator interaction was fragile. New model: previewScale is the only tracked value. In fullscreen it may overshoot down to 0.75*fit so the user *sees* the page pull away as they pinch out. On commit: - started near fit (<=1.05*fit) AND preview <0.9*fit -> exit to inline - otherwise clamp committed scale to >=fit (overshoot snaps back) beginPinch seeds fitScaleAtPinchStart synchronously from when !userHasZoomed (the common enter-fullscreen-at-fit case) so the first frame already has the right floor; the async computeFitScale refines it. * test(pdf-server): update inline-pinch e2e for new fullscreen behavior 'trackpad pinch is ignored outside fullscreen' is no longer the contract. Replace with two tests: pinch-in inline -> .main.fullscreen appears; pinch-out inline -> zoom unchanged, no fullscreen. The two pdf-annotations.spec.ts failures in the previous run were flaky (passed on retry).
316 lines
9.5 KiB
TypeScript
316 lines
9.5 KiB
TypeScript
import { test, expect, type Page } from "@playwright/test";
|
|
|
|
// Increase timeout for these tests — PDF loading from arxiv can be slow
|
|
test.setTimeout(120000);
|
|
|
|
/**
|
|
* PDF Annotation E2E Tests
|
|
*
|
|
* Tests the annotation capabilities of the PDF server through the basic-host UI.
|
|
* Verifies that annotations can be added, rendered, and interacted with.
|
|
*/
|
|
|
|
/** Wait for the MCP App to load inside nested iframes. */
|
|
async function waitForAppLoad(page: Page) {
|
|
const outerFrame = page.frameLocator("iframe").first();
|
|
await expect(outerFrame.locator("iframe")).toBeVisible({ timeout: 30000 });
|
|
}
|
|
|
|
/** Get the app frame locator (nested: sandbox > app) */
|
|
function getAppFrame(page: Page) {
|
|
return page.frameLocator("iframe").first().frameLocator("iframe").first();
|
|
}
|
|
|
|
/** Load the PDF server and call display_pdf with the default PDF. */
|
|
async function loadPdfServer(page: Page) {
|
|
await page.goto("/?theme=hide");
|
|
await expect(page.locator("select").first()).toBeEnabled({ timeout: 30000 });
|
|
await page.locator("select").first().selectOption({ label: "PDF Server" });
|
|
await page.click('button:has-text("Call Tool")');
|
|
await waitForAppLoad(page);
|
|
}
|
|
|
|
/**
|
|
* Extract the viewUUID from the display_pdf result panel.
|
|
* The tool result is displayed as JSON in a collapsible panel.
|
|
*/
|
|
async function extractViewUUID(page: Page): Promise<string> {
|
|
// Wait for the Tool Result panel to appear — it contains "📤 Tool Result"
|
|
const resultPanel = page.locator('text="📤 Tool Result"').first();
|
|
await expect(resultPanel).toBeVisible({ timeout: 30000 });
|
|
|
|
// The result preview shows the first 100 chars including "viewUUID: ..."
|
|
// Click to expand the result panel to see the full JSON
|
|
await resultPanel.click();
|
|
|
|
// Wait for the expanded result content to appear
|
|
const resultContent = page.locator("pre").last();
|
|
await expect(resultContent).toBeVisible({ timeout: 5000 });
|
|
|
|
const resultText = (await resultContent.textContent()) ?? "";
|
|
|
|
// Extract viewUUID from the JSON result
|
|
// The text content includes: "PDF opened. viewUUID: <uuid>"
|
|
const match = resultText.match(/viewUUID["\s:]+([a-f0-9-]{36})/);
|
|
if (!match) {
|
|
throw new Error(
|
|
`Could not extract viewUUID from result: ${resultText.slice(0, 200)}`,
|
|
);
|
|
}
|
|
return match[1];
|
|
}
|
|
|
|
/**
|
|
* Call the interact tool with the given input JSON.
|
|
* Selects the interact tool from the dropdown, fills the input, and clicks Call Tool.
|
|
*/
|
|
async function callInteract(page: Page, input: Record<string, unknown>) {
|
|
// Select "interact" in the tool dropdown (second select on the page)
|
|
const toolSelect = page.locator("select").nth(1);
|
|
await toolSelect.selectOption("interact");
|
|
|
|
// Fill the input textarea with the JSON
|
|
const inputTextarea = page.locator("textarea");
|
|
await inputTextarea.fill(JSON.stringify(input));
|
|
|
|
// Click "Call Tool"
|
|
await page.click('button:has-text("Call Tool")');
|
|
}
|
|
|
|
/** Wait for the PDF canvas to render (ensures the page is ready for annotations). */
|
|
async function waitForPdfCanvas(page: Page) {
|
|
const appFrame = getAppFrame(page);
|
|
await expect(appFrame.locator("canvas").first()).toBeVisible({
|
|
timeout: 30000,
|
|
});
|
|
// Wait a bit for fonts and text layer to stabilize
|
|
await page.waitForTimeout(2000);
|
|
}
|
|
|
|
test.describe("PDF Server - Annotations", () => {
|
|
test("display_pdf result includes viewUUID and interactEnabled meta", async ({
|
|
page,
|
|
}) => {
|
|
await loadPdfServer(page);
|
|
|
|
// Wait for result to appear
|
|
const resultPanel = page.locator('text="📤 Tool Result"').first();
|
|
await expect(resultPanel).toBeVisible({ timeout: 30000 });
|
|
|
|
// Expand the result panel
|
|
await resultPanel.click();
|
|
const resultContent = page.locator("pre").last();
|
|
await expect(resultContent).toBeVisible({ timeout: 5000 });
|
|
const resultText = (await resultContent.textContent()) ?? "";
|
|
|
|
// The result should carry the viewUUID and interact flag in _meta / structuredContent
|
|
// (interact action list lives in the tool description, not the runtime result).
|
|
expect(resultText).toContain("viewUUID");
|
|
expect(resultText).toContain("interactEnabled");
|
|
expect(resultText).toContain("PDF opened");
|
|
});
|
|
|
|
test("interact tool is available in tool dropdown", async ({ page }) => {
|
|
await loadPdfServer(page);
|
|
|
|
// Verify the interact tool is available in the tool dropdown
|
|
const toolSelect = page.locator("select").nth(1);
|
|
const options = await toolSelect.locator("option").allTextContents();
|
|
expect(options).toContain("interact");
|
|
});
|
|
|
|
test("add_annotations renders highlight on the page", async ({ page }) => {
|
|
await loadPdfServer(page);
|
|
await waitForPdfCanvas(page);
|
|
|
|
const viewUUID = await extractViewUUID(page);
|
|
|
|
// Add a highlight annotation on page 1
|
|
await callInteract(page, {
|
|
viewUUID,
|
|
action: "add_annotations",
|
|
annotations: [
|
|
{
|
|
id: "test-highlight-1",
|
|
type: "highlight",
|
|
page: 1,
|
|
rects: [{ x: 72, y: 700, width: 300, height: 14 }],
|
|
color: "rgba(255, 255, 0, 0.4)",
|
|
},
|
|
],
|
|
});
|
|
|
|
// Wait for the interact result
|
|
await page.waitForTimeout(1000);
|
|
|
|
// Verify the annotation appears in the annotation layer inside the app frame
|
|
const appFrame = getAppFrame(page);
|
|
const annotationLayer = appFrame.locator("#annotation-layer");
|
|
await expect(annotationLayer).toBeVisible({ timeout: 5000 });
|
|
|
|
// Check that a highlight annotation element was rendered
|
|
const highlightEl = appFrame.locator(".annotation-highlight");
|
|
await expect(highlightEl.first()).toBeVisible({ timeout: 5000 });
|
|
// Regression: highlight must be translucent (not opaque hex), so text
|
|
// underneath remains readable.
|
|
await expect(highlightEl.first()).toHaveCSS(
|
|
"background-color",
|
|
/rgba\(255, 255, 0, 0\.35\)/,
|
|
);
|
|
});
|
|
|
|
test("add_annotations renders multiple annotation types", async ({
|
|
page,
|
|
}) => {
|
|
await loadPdfServer(page);
|
|
await waitForPdfCanvas(page);
|
|
|
|
const viewUUID = await extractViewUUID(page);
|
|
|
|
// Add multiple annotation types at once
|
|
await callInteract(page, {
|
|
viewUUID,
|
|
action: "add_annotations",
|
|
annotations: [
|
|
{
|
|
id: "test-highlight",
|
|
type: "highlight",
|
|
page: 1,
|
|
rects: [{ x: 72, y: 700, width: 300, height: 14 }],
|
|
color: "rgba(255, 255, 0, 0.4)",
|
|
},
|
|
{
|
|
id: "test-note",
|
|
type: "note",
|
|
page: 1,
|
|
x: 400,
|
|
y: 600,
|
|
content: "Important finding!",
|
|
color: "#ffeb3b",
|
|
},
|
|
{
|
|
id: "test-stamp",
|
|
type: "stamp",
|
|
page: 1,
|
|
x: 300,
|
|
y: 400,
|
|
label: "APPROVED",
|
|
color: "#4caf50",
|
|
rotation: -15,
|
|
},
|
|
{
|
|
id: "test-freetext",
|
|
type: "freetext",
|
|
page: 1,
|
|
x: 100,
|
|
y: 300,
|
|
content: "See section 3.2",
|
|
fontSize: 14,
|
|
color: "#1976d2",
|
|
},
|
|
{
|
|
id: "test-rect",
|
|
type: "rectangle",
|
|
page: 1,
|
|
x: 50,
|
|
y: 200,
|
|
width: 500,
|
|
height: 100,
|
|
color: "#f44336",
|
|
},
|
|
],
|
|
});
|
|
|
|
await page.waitForTimeout(1500);
|
|
|
|
const appFrame = getAppFrame(page);
|
|
|
|
// Verify each annotation type is rendered
|
|
await expect(appFrame.locator(".annotation-highlight").first()).toBeVisible(
|
|
{
|
|
timeout: 5000,
|
|
},
|
|
);
|
|
await expect(appFrame.locator(".annotation-note").first()).toBeVisible({
|
|
timeout: 5000,
|
|
});
|
|
await expect(appFrame.locator(".annotation-stamp").first()).toBeVisible({
|
|
timeout: 5000,
|
|
});
|
|
await expect(appFrame.locator(".annotation-freetext").first()).toBeVisible({
|
|
timeout: 5000,
|
|
});
|
|
await expect(appFrame.locator(".annotation-rectangle").first()).toBeVisible(
|
|
{ timeout: 5000 },
|
|
);
|
|
});
|
|
|
|
test("remove_annotations removes annotation from DOM", async ({ page }) => {
|
|
await loadPdfServer(page);
|
|
await waitForPdfCanvas(page);
|
|
|
|
const viewUUID = await extractViewUUID(page);
|
|
|
|
// Add an annotation
|
|
await callInteract(page, {
|
|
viewUUID,
|
|
action: "add_annotations",
|
|
annotations: [
|
|
{
|
|
id: "to-remove",
|
|
type: "highlight",
|
|
page: 1,
|
|
rects: [{ x: 72, y: 700, width: 300, height: 14 }],
|
|
},
|
|
],
|
|
});
|
|
|
|
await page.waitForTimeout(1000);
|
|
|
|
const appFrame = getAppFrame(page);
|
|
await expect(appFrame.locator(".annotation-highlight").first()).toBeVisible(
|
|
{
|
|
timeout: 5000,
|
|
},
|
|
);
|
|
|
|
// Remove the annotation
|
|
await callInteract(page, {
|
|
viewUUID,
|
|
action: "remove_annotations",
|
|
ids: ["to-remove"],
|
|
});
|
|
|
|
await page.waitForTimeout(1000);
|
|
|
|
// Verify the annotation is gone
|
|
await expect(appFrame.locator(".annotation-highlight")).toHaveCount(0, {
|
|
timeout: 5000,
|
|
});
|
|
});
|
|
|
|
test("highlight_text finds and highlights text", async ({ page }) => {
|
|
await loadPdfServer(page);
|
|
await waitForPdfCanvas(page);
|
|
|
|
const viewUUID = await extractViewUUID(page);
|
|
|
|
// Use highlight_text to find and highlight "Attention" in the PDF
|
|
await callInteract(page, {
|
|
viewUUID,
|
|
action: "highlight_text",
|
|
query: "Attention",
|
|
color: "rgba(0, 200, 255, 0.4)",
|
|
});
|
|
|
|
await page.waitForTimeout(2000);
|
|
|
|
const appFrame = getAppFrame(page);
|
|
// highlight_text creates highlight annotations, so we should see at least one
|
|
await expect(appFrame.locator(".annotation-highlight").first()).toBeVisible(
|
|
{
|
|
timeout: 10000,
|
|
},
|
|
);
|
|
});
|
|
});
|