ext-apps/scripts/check-dependency-isolation.mjs
Olivier Chafik f28f5ddb3c Harden dependency isolation check and run it in CI
npm pack runs the prepare script for directory specs even with
--ignore-scripts and its output can pollute stdout, so locate the packed
tarball on disk instead of parsing --json output. Run npm with a minimal
environment so caller npm config cannot leak into the synthetic
consumers, and require exact versions for the consumers' dependencies.
Add a CI job that runs the check on Node 22.
2026-09-08 13:58:21 +01:00

183 lines
5.5 KiB
JavaScript

import { execFileSync } from "node:child_process";
import {
mkdtempSync,
mkdirSync,
readdirSync,
readFileSync,
rmSync,
writeFileSync,
} from "node:fs";
import { tmpdir } from "node:os";
import { join, resolve } from "node:path";
const root = resolve(import.meta.dirname, "..");
const packageJson = JSON.parse(
readFileSync(join(root, "package.json"), "utf8"),
);
const client = "@modelcontextprotocol/client";
const server = "@modelcontextprotocol/server";
for (const role of [client, server]) {
if (!packageJson.peerDependencies?.[role]) {
throw new Error(`${role} must remain a peer dependency`);
}
if (packageJson.peerDependenciesMeta?.[role]?.optional !== true) {
throw new Error(`${role} must be an optional peer dependency`);
}
}
/**
* Exact version for a synthetic consumer dependency. Read from
* devDependencies so the consumers exercise the same SDK version the
* repository tests against; the check would silently drift if a range were
* allowed here.
*/
function exactDevDependency(name) {
const version = packageJson.devDependencies?.[name];
if (!/^\d+\.\d+\.\d+(-[0-9A-Za-z.-]+)?$/.test(version ?? "")) {
throw new Error(
`devDependencies["${name}"] must be an exact version, got ${JSON.stringify(version)}`,
);
}
return version;
}
const temporaryRoot = mkdtempSync(join(tmpdir(), "ext-apps-role-peers-"));
try {
// Minimal environment: nothing inherited from the caller's npm config
// (registry overrides, auth tokens, npm_config_* set by an outer `npm run`)
// can leak into the synthetic consumers.
const npmEnvironment = {
PATH: process.env.PATH ?? process.env.Path,
HOME: process.env.HOME ?? process.env.USERPROFILE,
npm_config_cache: join(temporaryRoot, "npm-cache"),
};
const packDestination = join(temporaryRoot, "pack");
mkdirSync(packDestination);
// `npm pack` runs the package's `prepare` script even with --ignore-scripts
// (pacote's directory fetcher), and its output can pollute stdout, so do not
// rely on `--json`: locate the tarball on disk instead.
execFileSync(
"npm",
["pack", "--ignore-scripts", "--pack-destination", packDestination],
{ cwd: root, stdio: "pipe", env: npmEnvironment },
);
const tarballs = readdirSync(packDestination).filter((name) =>
name.endsWith(".tgz"),
);
if (tarballs.length !== 1) {
throw new Error(`expected exactly one tarball, found ${tarballs}`);
}
const tarball = join(packDestination, tarballs[0]);
const consumers = [
{
name: "app-only",
dependencies: {
"@types/node": exactDevDependency("@types/node"),
[client]: exactDevDependency(client),
"@modelcontextprotocol/ext-apps": `file:${tarball}`,
},
absent: server,
entry:
'import { App } from "@modelcontextprotocol/ext-apps"; import { AppBridge } from "@modelcontextprotocol/ext-apps/app-bridge"; console.log(App, AppBridge);',
},
{
name: "server-only",
dependencies: {
"@types/node": exactDevDependency("@types/node"),
"@modelcontextprotocol/ext-apps": `file:${tarball}`,
[server]: exactDevDependency(server),
},
absent: client,
entry:
'import { registerAppTool } from "@modelcontextprotocol/ext-apps/server"; console.log(registerAppTool);',
},
];
for (const consumer of consumers) {
const directory = join(temporaryRoot, consumer.name);
mkdirSync(directory);
writeFileSync(
join(directory, "package.json"),
JSON.stringify({
private: true,
type: "module",
dependencies: consumer.dependencies,
}),
);
execFileSync(
"npm",
[
"install",
"--ignore-scripts",
"--package-lock=false",
"--no-audit",
"--no-fund",
],
{ cwd: directory, stdio: "pipe", env: npmEnvironment },
);
const absentPath = join(
directory,
"node_modules",
...consumer.absent.split("/"),
"package.json",
);
try {
readFileSync(absentPath);
throw new Error(
`${consumer.name} unexpectedly installed ${consumer.absent}`,
);
} catch (error) {
if (error?.code !== "ENOENT") throw error;
}
writeFileSync(join(directory, "entry.ts"), consumer.entry);
writeFileSync(
join(directory, "tsconfig.json"),
JSON.stringify({
compilerOptions: {
lib: ["ES2020", "DOM"],
module: "ESNext",
moduleResolution: "bundler",
noEmit: true,
skipLibCheck: false,
strict: true,
target: "ES2020",
},
include: ["entry.ts"],
}),
);
execFileSync(
process.execPath,
[join(root, "node_modules", "typescript", "bin", "tsc")],
{ cwd: directory, stdio: "inherit" },
);
const metafile = join(directory, "bundle-meta.json");
execFileSync(
join(root, "node_modules", ".bin", "esbuild"),
[
"entry.ts",
"--bundle",
"--platform=browser",
"--outfile=bundle.js",
`--metafile=${metafile}`,
],
{ cwd: directory, stdio: "pipe" },
);
const bundleInputs = Object.keys(
JSON.parse(readFileSync(metafile, "utf8")).inputs,
).join("\n");
if (bundleInputs.includes(`/node_modules/${consumer.absent}/`)) {
throw new Error(
`${consumer.name} unexpectedly bundled ${consumer.absent}`,
);
}
}
} finally {
rmSync(temporaryRoot, { recursive: true, force: true });
}
console.log("Role peer dependency isolation checks passed.");