modelcontextprotocol/go-sdk
Watch
1
0
Fork
You've already forked go-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

internal/mcp: fix prompt example

Browse source 
The hello example was using params.Name, which is the name of the
prompt. It should use args.Name.

Change-Id: I0e7e992bbe312fd5a6e56e9bc46a931f0eeb423c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/682416
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Jonathan Amsterdam 2025-06-18 01:40:10 -04:00
commit 0160cdefa0
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
examples/hello/main.go
View file

@ -32,11 +32,11 @@ func SayHi(ctx context.Context, ss *mcp.ServerSession, params *mcp.CallToolParam
// TODO(jba): it should be OK for args to be a pointer, but this fails in
// jsonschema. Needs investigation.
func PromptHi(ctx context.Context, ss *mcp.ServerSession, args HiArgs, params *mcp.GetPromptParams) (*mcp.GetPromptResult, error) {
func PromptHi(ctx context.Context, ss *mcp.ServerSession, args HiArgs, _ *mcp.GetPromptParams) (*mcp.GetPromptResult, error) {
return &mcp.GetPromptResult{
Description: "Code review prompt",
Messages: []*mcp.PromptMessage{
{Role: "user", Content: mcp.NewTextContent("Say hi to " + params.Name)},
{Role: "user", Content: mcp.NewTextContent("Say hi to " + args.Name)},
},
}, nil
}

6
mcp/prompt.go
View file

@ -75,11 +75,11 @@ func NewServerPrompt[In any](name, description string, handler func(context.Cont
if err != nil {
return nil, err
}
var v In
if err := unmarshalSchema(rawArgs, resolved, &v); err != nil {
var args In
if err := unmarshalSchema(rawArgs, resolved, &args); err != nil {
return nil, err
}
return handler(ctx, ss, v, params)
return handler(ctx, ss, args, params)
}
for _, opt := range opts {
opt.set(prompt)