modelcontextprotocol/go-sdk
Watch
1
0
Fork
You've already forked go-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

mcp: use correct ResourceNotFound code (#35)

Browse source
This commit is contained in:
Jonathan Amsterdam 2025-06-25 14:57:07 -04:00 • committed by GitHub
commit 09181c2c2e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/jsonrpc2/wire.go
View file

@ -34,7 +34,7 @@ var (
// ErrUnknown should be used for all non coded errors. // ErrUnknown should be used for all non coded errors.
ErrUnknown = NewError(-32001, "JSON RPC unknown error") ErrUnknown = NewError(-32001, "JSON RPC unknown error")
// ErrServerClosing is returned for calls that arrive while the server is closing. // ErrServerClosing is returned for calls that arrive while the server is closing.
ErrServerClosing = NewError(-32002, "JSON RPC server is closing") ErrServerClosing = NewError(-32004, "JSON RPC server is closing")
// ErrClientClosing is a dummy error returned for calls initiated while the client is closing. // ErrClientClosing is a dummy error returned for calls initiated while the client is closing.
ErrClientClosing = NewError(-32003, "JSON RPC client is closing") ErrClientClosing = NewError(-32003, "JSON RPC client is closing")
) )

8
mcp/shared.go
View file

@ -207,13 +207,7 @@ func sessionMethod[S Session, P Params, R Result](f func(S, context.Context, P)
// Error codes // Error codes
const ( const (
// The error code to return when a resource isn't found. CodeResourceNotFound = -32002
// See https://modelcontextprotocol.io/specification/2025-03-26/server/resources#error-handling
// However, the code they chose is in the wrong space
// (see https://github.com/modelcontextprotocol/modelcontextprotocol/issues/509).
// so we pick a different one, arbitrarily for now (until they fix it).
// The immediate problem is that jsonprc2 defines -32002 as "server closing".
CodeResourceNotFound = -31002
// The error code if the method exists and was called properly, but the peer does not support it. // The error code if the method exists and was called properly, but the peer does not support it.
CodeUnsupportedMethod = -31001 CodeUnsupportedMethod = -31001
) )