modelcontextprotocol/go-sdk
Watch
1
0
Fork
You've already forked go-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

mcp: address some comments from #234 (#248)

Browse source 
I inadvertently merged #234 without pushing my latest patches. This CL
adds the missing changes.
This commit is contained in:
Robert Findley 2025-08-11 12:45:14 -04:00 • committed by GitHub
commit 119a58314d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
mcp/cmd_test.go
View file

@ -129,7 +129,9 @@ func TestServerInterrupt(t *testing.T) {
}()
// send a signal to the server process to terminate it
cmd.Process.Signal(os.Interrupt)
if err := cmd.Process.Signal(os.Interrupt); err != nil {
t.Fatal(err)
}
// wait for the server to exit
// TODO: use synctest when available
@ -162,6 +164,11 @@ func TestStdioContextCancellation(t *testing.T) {
}
// Sleep to make it more likely that the server is blocked in the read loop.
//
// This sleep isn't necessary for the test to pass, but *was* necessary for
// it to fail, before closing was fixed. Unfortunately, it is too invasive a
// change to have the jsonrpc2 package signal across packages when it is
// actually blocked in its read loop.
time.Sleep(100 * time.Millisecond)
onExit := make(chan struct{})
@ -170,7 +177,9 @@ func TestStdioContextCancellation(t *testing.T) {
close(onExit)
}()
cmd.Process.Signal(os.Interrupt)
if err := cmd.Process.Signal(os.Interrupt); err != nil {
t.Fatal(err)
}
select {
case <-time.After(5 * time.Second):