mcp: improve http transports error handling and make transport work with any size message (#734)
We have a use case for messages larger than 1MB, hence making this configurable would help. In order to discover the source of our problems we had to spend some time investigating, as errors were silently discarded. So we also included changes to improving surfacing errors . --------- Co-authored-by: Maciej Kisiel <macio92@gmail.com>
This commit is contained in:
parent
8a39cf6ce0
commit
1fb6e204d7
1 changed files with 116 additions and 29 deletions
|
|
@ -55,6 +55,78 @@ func TestScanEvents(t *testing.T) {
|
|||
input: "invalid line\n\n",
|
||||
wantErr: "malformed line",
|
||||
},
|
||||
{
|
||||
name: "message with 2 data lines and another event",
|
||||
input: "event: message\ndata: hello\ndata: hello\ndata: hello\n\nevent:keepalive",
|
||||
want: []Event{
|
||||
{Name: "message", Data: []byte("hello\nhello\nhello")},
|
||||
{Name: "keepalive"},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "event with multiple lines",
|
||||
input: "event: message\ndata: hello\ndata: hello\ndata: hello\nid:1",
|
||||
want: []Event{
|
||||
{Name: "message", ID: "1", Data: []byte("hello\nhello\nhello")},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "multiple events, out of order keys",
|
||||
input: strings.Join([]string{
|
||||
"event:message",
|
||||
"data: hello0",
|
||||
"\n",
|
||||
"data: hello1",
|
||||
"data: hello1",
|
||||
"id:1",
|
||||
"event:message",
|
||||
"\n",
|
||||
"event:message",
|
||||
"data: hello3",
|
||||
"data: hello3",
|
||||
"id:3",
|
||||
"\n",
|
||||
"data: hello4",
|
||||
"data: hello4",
|
||||
"id:4",
|
||||
"event:message",
|
||||
}, "\n"),
|
||||
want: []Event{
|
||||
{Name: "message", Data: []byte("hello0")},
|
||||
{Name: "message", ID: "1", Data: []byte("hello1\nhello1")},
|
||||
{Name: "message", ID: "3", Data: []byte("hello3\nhello3")},
|
||||
{Name: "message", ID: "4", Data: []byte("hello4\nhello4")},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "non-continuous data items in the event",
|
||||
input: "event: foo\ndata: 123\nretry: 5\ndata: 456",
|
||||
want: []Event{
|
||||
{Name: "foo", Data: []byte("123\n456"), Retry: "5"},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "no-data events",
|
||||
input: "event: foo\n\nevent: bar",
|
||||
want: []Event{
|
||||
{Name: "foo"},
|
||||
{Name: "bar"},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "empty data event",
|
||||
input: "event: foo\ndata:\n\nevent: bar",
|
||||
want: []Event{
|
||||
{Name: "foo"},
|
||||
{Name: "bar"},
|
||||
},
|
||||
},
|
||||
{
|
||||
|
||||
name: "malformed data event",
|
||||
input: "someline",
|
||||
wantErr: "malformed event",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
|
|
|
|||
Loading…
Reference in a new issue