fix: handle oauth2.RetrieveError during token refresh (#917)
Previously, an expired refresh token in the oauth2.Token returned from OAuthHandler.TokenSource() would cause the connection to fail. From the client perspective, this meant that the MCP connection was in a hard-failed state with no way to re-authorize. The change in this commit causes Authorize() to be called in the event of both an oauth2.RetrieveError from the token endpoint, as well as in the pre-existing case of a 401/403 HTTP response from the MCP server. Clients will handle this in their existing Authorize() flows to get a new valid token for the connection. Supersedes and closes: #909. Co-authored-by: Yaroslav <yarolegovich@gmail.com>
This commit is contained in:
parent
8e45782dbd
commit
4f1b3e5062
1 changed files with 72 additions and 3 deletions
|
|
@ -6,6 +6,7 @@ package mcp
|
|||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"net/http"
|
||||
|
|
@ -1156,3 +1157,58 @@ func TestTokenInfo(t *testing.T) {
|
|||
t.Errorf("got %q, want %q", g, w)
|
||||
}
|
||||
}
|
||||
|
||||
// errTestAuthorizeFailed is a sentinel error returned by
|
||||
// retrieveErrorOAuthHandler.Authorize().
|
||||
var errTestAuthorizeFailed = errors.New("authorize intentionally failed for test")
|
||||
|
||||
// retrieveErrorOAuthHandler is a mock OAuthHandler that always returns
|
||||
// an oauth2.RetrieveError from its TokenSource's Token() method.
|
||||
type retrieveErrorOAuthHandler struct{}
|
||||
|
||||
func (h *retrieveErrorOAuthHandler) TokenSource(ctx context.Context) (oauth2.TokenSource, error) {
|
||||
return h, nil
|
||||
}
|
||||
|
||||
func (h *retrieveErrorOAuthHandler) Token() (*oauth2.Token, error) {
|
||||
return nil, &oauth2.RetrieveError{
|
||||
Response: &http.Response{StatusCode: http.StatusBadRequest},
|
||||
Body: []byte("test retrieve error"),
|
||||
ErrorCode: "invalid_grant",
|
||||
}
|
||||
}
|
||||
|
||||
func (h *retrieveErrorOAuthHandler) Authorize(ctx context.Context, req *http.Request, resp *http.Response) error {
|
||||
return errTestAuthorizeFailed
|
||||
}
|
||||
|
||||
// TestStreamableClientOAuth_RetrieveError verifies that an invalid_grant RetrieveError
|
||||
// from the OAuth token source correctly skips sending Authorization header and relies on
|
||||
// the server's 401 response to trigger the Authorize fallback flow.
|
||||
func TestStreamableClientOAuth_RetrieveError(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
oauthHandler := &retrieveErrorOAuthHandler{}
|
||||
|
||||
// Mock MCP server returns 401 Unauthorized to simulate a server rejecting
|
||||
// the request that omitted the Authorization header.
|
||||
httpServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.WriteHeader(http.StatusUnauthorized)
|
||||
}))
|
||||
t.Cleanup(httpServer.Close)
|
||||
|
||||
transport := &StreamableClientTransport{
|
||||
Endpoint: httpServer.URL,
|
||||
OAuthHandler: oauthHandler,
|
||||
}
|
||||
client := NewClient(testImpl, nil)
|
||||
|
||||
// Attempt to connect. The Connect call will trigger the initialization request,
|
||||
// which will fail to retrieve the token and proceed without auth header, receive 401,
|
||||
// and invoke Authorize().
|
||||
_, err := client.Connect(ctx, transport, nil)
|
||||
|
||||
// Expect the connection to fail with the sentinel error, not the RetrieveError.
|
||||
if !errors.Is(err, errTestAuthorizeFailed) {
|
||||
t.Fatalf("client.Connect() error = %v, want %v", err, errTestAuthorizeFailed)
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue