mcp: reject notifications with unexpected ID field (#204)

Use the new 'isRequest' field on methodInfo to also reject notifications
with an unexpected ID field.

For #196
This commit is contained in:
Robert Findley 2025-07-30 15:19:51 -04:00 • committed by GitHub
commit 56734edf46
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -0,0 +1,64 @@
Check robustness to missing fields: servers should reject and otherwise ignore
bad requests.
Fixed bugs:
- No id in 'initialize' should not panic (#197).
- No id in 'ping' should not panic (#194).
- Notifications with IDs should not be treated like requests.
TODO:
- No params in 'initialize' should not panic (#195).
-- prompts --
code_review
-- client --
{
"jsonrpc": "2.0",
"method": "initialize",
"params": {
"protocolVersion": "2024-11-05",
"capabilities": {},
"clientInfo": { "name": "ExampleClient", "version": "1.0.0" }
}
}
{
"jsonrpc": "2.0",
"id": 2,
"method": "initialize",
"params": {
"protocolVersion": "2024-11-05",
"capabilities": {},
"clientInfo": { "name": "ExampleClient", "version": "1.0.0" }
}
}
{"jsonrpc":"2.0", "id": 3, "method":"notifications/initialized"}
{"jsonrpc":"2.0", "method":"ping"}
-- server --
{
"jsonrpc": "2.0",
"id": 2,
"result": {
"capabilities": {
"completions": {},
"logging": {},
"prompts": {
"listChanged": true
}
},
"protocolVersion": "2024-11-05",
"serverInfo": {
"name": "testServer",
"version": "v1.0.0"
}
}
}
{
"jsonrpc": "2.0",
"id": 3,
"error": {
"code": -32600,
"message": "JSON RPC invalid request: unexpected id for \"notifications/initialized\""
}
}