modelcontextprotocol/go-sdk
Watch
1
0
Fork
You've already forked go-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

mcp: NewClient and NewServer take Implementation (#113)

Browse source 
Change the name and version arguments to NewClient and NewServer to a
`*Implementation`, to future-proof against the spec.

Fixes #109.
This commit is contained in:
Jonathan Amsterdam 2025-07-10 16:57:38 -04:00 • committed by GitHub
commit 6c6243c0b0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 76 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

12
mcp/cmd_test.go
View file

@ -32,7 +32,7 @@ func TestMain(m *testing.M) {
func runServer() {
ctx := context.Background()
server := mcp.NewServer("greeter", "v0.0.1", nil)
server := mcp.NewServer(testImpl, nil)
mcp.AddTool(server, &mcp.Tool{Name: "greet", Description: "say hi"}, SayHi)
if err := server.Run(ctx, mcp.NewStdioTransport()); err != nil {
log.Fatal(err)
@ -40,7 +40,7 @@ func runServer() {
}
func TestServerRunContextCancel(t *testing.T) {
server := mcp.NewServer("greeter", "v0.0.1", nil)
server := mcp.NewServer(&mcp.Implementation{Name: "greeter", Version: "v0.0.1"}, nil)
mcp.AddTool(server, &mcp.Tool{Name: "greet", Description: "say hi"}, SayHi)
ctx, cancel := context.WithCancel(context.Background())
@ -55,7 +55,7 @@ func TestServerRunContextCancel(t *testing.T) {
}()
// send a ping to the server to ensure it's running
client := mcp.NewClient("client", "v0.0.1", nil)
client := mcp.NewClient(&mcp.Implementation{Name: "client", Version: "v0.0.1"}, nil)
session, err := client.Connect(ctx, clientTransport)
if err != nil {
t.Fatal(err)
@ -87,7 +87,7 @@ func TestServerInterrupt(t *testing.T) {
cmd := createServerCommand(t)
client := mcp.NewClient("client", "v0.0.1", nil)
client := mcp.NewClient(testImpl, nil)
session, err := client.Connect(ctx, mcp.NewCommandTransport(cmd))
if err != nil {
t.Fatal(err)
@ -125,7 +125,7 @@ func TestCmdTransport(t *testing.T) {
cmd := createServerCommand(t)
client := mcp.NewClient("client", "v0.0.1", nil)
client := mcp.NewClient(&mcp.Implementation{Name: "client", Version: "v0.0.1"}, nil)
session, err := client.Connect(ctx, mcp.NewCommandTransport(cmd))
if err != nil {
t.Fatal(err)
@ -174,3 +174,5 @@ func requireExec(t *testing.T) {
t.Skip("unsupported OS")
}
}
var testImpl = &mcp.Implementation{Name: "test", Version: "v1.0.0"}