internal/mcp/jsonschema: check that schemas form a tree

When we check the root schema during resolution, first make sure
its descendants form a tree.

Change-Id: Icc430e7df463aa84b961c28616be567f98960430
Reviewed-on: https://go-review.googlesource.com/c/tools/+/670776
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
This commit is contained in:
Jonathan Amsterdam 2025-05-07 21:11:11 -04:00
commit 8056e5a472

View file

@ -10,6 +10,7 @@ import (
"net/url"
"regexp"
"slices"
"strings"
"testing"
)
@ -40,6 +41,22 @@ func TestCheckLocal(t *testing.T) {
}
}
func TestSchemaNonTree(t *testing.T) {
run := func(s *Schema, kind string) {
err := s.check()
if err == nil || !strings.Contains(err.Error(), "tree") {
t.Fatalf("did not detect %s", kind)
}
}
s := &Schema{Type: "number"}
run(&Schema{Items: s, Contains: s}, "DAG")
root := &Schema{Items: s}
s.Items = root
run(root, "cycle")
}
func TestResolveURIs(t *testing.T) {
for _, baseURI := range []string{"", "http://a.com"} {
t.Run(baseURI, func(t *testing.T) {