modelcontextprotocol/go-sdk
Watch
1
0
Fork
You've already forked go-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

mcp: wrap unmarshalParams with jsonrpc error (#1087)

Browse source 
Fixes #976
This commit is contained in:
Guglielmo Colombo 2026-07-14 16:26:18 +02:00 • committed by GitHub
commit 9576afc114
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 63 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

26
mcp/shared_test.go
View file

@ -512,3 +512,29 @@ func TestImplementationDescriptionJSON(t *testing.T) {
// }
// })
// }
// TestUnmarshalParamsInvalidParamsCode is a regression test for
// https://github.com/modelcontextprotocol/go-sdk/issues/976#issuecomment-4829124838.
// Malformed params for a registered method must surface as a JSON-RPC error
// whose code is CodeInvalidParams (-32602) rather than the zero-value 0.
func TestUnmarshalParamsInvalidParamsCode(t *testing.T) {
info, ok := serverMethodInfos[methodPing]
if !ok {
t.Fatalf("no methodInfo for %q", methodPing)
}
// Array where a struct is expected.
_, err := info.unmarshalParams(json.RawMessage(`["a","b"]`))
if err == nil {
t.Fatal("unmarshalParams returned nil error for malformed params")
}
var jerr *jsonrpc.Error
if !errors.As(err, &jerr) {
t.Fatalf("expected *jsonrpc.Error in chain, got %T: %v", err, err)
}
if jerr.Code != jsonrpc.CodeInvalidParams {
t.Errorf("error code = %d, want %d (CodeInvalidParams)", jerr.Code, jsonrpc.CodeInvalidParams)
}
if !strings.Contains(err.Error(), "unmarshaling") {
t.Errorf("error message = %q, want it to mention unmarshaling", err.Error())
}
}