mcp: limit SSE discover supportedVersions to SSE-defined revisions (#1121)
## Summary `NewSSEHandler` sessions were advertising `2026-07-28` in `server/discover` `supportedVersions`. That revision only defines stdio and Streamable HTTP, not the deprecated HTTP+SSE binding, so Modern-first clients could negotiate a revision the transport cannot honour. ## Changes - Implement `ProtocolVersionSupporter` on `SSEServerTransport` so `filterSupportedVersions` excludes `>= 2026-07-28` (matching the streamable transport's version gate pattern). - In `Server.discover`, only set session `InitializeParams` when the requested version is actually supported by the transport. Without this, a discover probe that returns only legacy versions still marked the session initialized, and the client's fallback `initialize` failed with `duplicate "initialize" received`. - Tests: unit coverage for filtered SSE versions, plus an end-to-end Modern client → SSE fallback-to-initialize path. Fixes #1112 ## Test plan - [x] `go test ./...` - [x] `go test ./mcp/ -run 'TestSSE|TestInMemory_E2E_Discover|TestStreamableStateful_AcceptsDiscover|TestStreamableHTTP_E2E_Discover|TestClientConnectDiscover'` Assistance: human-reviewed AI assistance used for implementation. --------- Co-authored-by: arimu1 <19286898+arimu1@users.noreply.github.com>
This commit is contained in:
parent
d462fbd303
commit
958dfcc532
1 changed files with 71 additions and 0 deletions
|
|
@ -189,6 +189,13 @@ func (t *SSEServerTransport) Connect(context.Context) (Connection, error) {
|
|||
return &sseServerConn{t: t}, nil
|
||||
}
|
||||
|
||||
// SupportsProtocolVersion reports whether the HTTP+SSE transport can serve the
|
||||
// given protocol version. MCP 2026-07-28 defines only the stdio and Streamable
|
||||
// HTTP bindings, so this (deprecated) transport does not advertise that revision.
|
||||
func (t *SSEServerTransport) SupportsProtocolVersion(version string) bool {
|
||||
return version < protocolVersion20260728
|
||||
}
|
||||
|
||||
func (h *SSEHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
|
||||
// DNS rebinding protection: auto-enabled for localhost servers.
|
||||
// See: https://modelcontextprotocol.io/specification/2025-11-25/basic/security_best_practices#local-mcp-server-compromise
|
||||
|
|
|
|||
Loading…
Reference in a new issue