modelcontextprotocol/go-sdk
Watch
1
0
Fork
You've already forked go-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

jsonrpc: paper over race in jsonrpc2 test

Browse source 
In jsonprc2_test.go, binder.Bind starts a goroutine.
That goroutine begins to run during jsonrpc2.bindConnection, and
can race with the setting of conn.write in bindConnection.

This PR adds a sleep, which is a poor way to deal with the race, but
the least invasive change. Better ones include running the test
function after Dial returns, or adding a Connection.Ready method
to detect when initialization is complete.
This commit is contained in:
Jonathan Amsterdam 2025-08-09 12:12:38 -04:00 • committed by Robert Findley
commit be1ddf5f80
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
internal/jsonrpc2/jsonrpc2_test.go
View file

@ -11,6 +11,7 @@ import (
"path" "path"
"reflect" "reflect"
"testing" "testing"
"time"
"github.com/modelcontextprotocol/go-sdk/internal/jsonrpc2" "github.com/modelcontextprotocol/go-sdk/internal/jsonrpc2"
) )
@ -143,6 +144,8 @@ func testConnection(t *testing.T, framer jsonrpc2.Framer) {
t.Run(test.Name(), func(t *testing.T) { t.Run(test.Name(), func(t *testing.T) {
client, err := jsonrpc2.Dial(ctx, client, err := jsonrpc2.Dial(ctx,
listener.Dialer(), binder{framer, func(h *handler) { listener.Dialer(), binder{framer, func(h *handler) {
// Sleep a little to a void a race with setting conn.writer in jsonrpc2.bindConnection.
time.Sleep(50 * time.Millisecond)
defer h.conn.Close() defer h.conn.Close()
test.Invoke(t, ctx, h) test.Invoke(t, ctx, h)
if call, ok := test.(*call); ok { if call, ok := test.(*call); ok {