fix: do not omitempty ReadOnlyHint in ToolAnnotations (#908)
`ReadOnlyHint` is a `bool` with omitempty, so the zero value (false) is indistinguishable from unset, and **drops out** of marshaled JSON. The current behavior causes an issue with the OpenAI MCP app submission because they require explicit hints. Consumers that explicitly set `ReadOnlyHint: false` on write tools lose the field on the wire. Removing `omitempty` ensures `false` is always serialized, which matches the MCP spec default. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Maciej Kisiel <mkisiel@google.com> Co-authored-by: guglielmoc <guglielmoc@google.com>
This commit is contained in:
parent
bed83e104b
commit
c044cdb734
1 changed files with 107 additions and 2 deletions
|
|
@ -1194,3 +1194,60 @@ func TestContentUnmarshal(t *testing.T) {
|
|||
var gotpm PromptMessage
|
||||
roundtrip(pm, &gotpm)
|
||||
}
|
||||
|
||||
func TestToolAnnotations_MarshalJSON(t *testing.T) {
|
||||
boolPtr := func(b bool) *bool { return &b }
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
in ToolAnnotations
|
||||
want string
|
||||
}{
|
||||
{
|
||||
name: "ZeroValue",
|
||||
in: ToolAnnotations{},
|
||||
want: `{"idempotentHint":false,"readOnlyHint":false}`,
|
||||
},
|
||||
{
|
||||
name: "AllFalse",
|
||||
in: ToolAnnotations{
|
||||
DestructiveHint: boolPtr(false),
|
||||
IdempotentHint: false,
|
||||
OpenWorldHint: boolPtr(false),
|
||||
ReadOnlyHint: false,
|
||||
},
|
||||
want: `{"destructiveHint":false,"idempotentHint":false,"openWorldHint":false,"readOnlyHint":false}`,
|
||||
},
|
||||
{
|
||||
name: "AllTrue",
|
||||
in: ToolAnnotations{
|
||||
DestructiveHint: boolPtr(true),
|
||||
IdempotentHint: true,
|
||||
OpenWorldHint: boolPtr(true),
|
||||
ReadOnlyHint: true,
|
||||
Title: "my tool",
|
||||
},
|
||||
want: `{"destructiveHint":true,"idempotentHint":true,"openWorldHint":true,"readOnlyHint":true,"title":"my tool"}`,
|
||||
},
|
||||
{
|
||||
name: "MixedValues",
|
||||
in: ToolAnnotations{
|
||||
ReadOnlyHint: true,
|
||||
Title: "read tool",
|
||||
},
|
||||
want: `{"idempotentHint":false,"readOnlyHint":true,"title":"read tool"}`,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
got, err := json.Marshal(tt.in)
|
||||
if err != nil {
|
||||
t.Fatalf("json.Marshal(%v) failed: %v", tt.in, err)
|
||||
}
|
||||
if diff := cmp.Diff(tt.want, string(got)); diff != "" {
|
||||
t.Errorf("json.Marshal() mismatch (-want +got):\n%s", diff)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue