modelcontextprotocol/go-sdk
Watch
1
0
Fork
You've already forked go-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

mcp: use http.ResponseController to ensure writes are flushed (#870)

Browse source 
If the ResponseWriter is a wrapped one (which is quite common when using
middleware to log things like response sizes), the direct cast to
`http.Flusher` doesn't find the flush capability. Instead, use
`http.ResponseController` as introduced in go1.20 which handles
unwrapping to find the base response writer.
This commit is contained in:
Dan McGee 2026-03-31 06:13:16 -05:00 • committed by GitHub
commit d3fd25b68a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

5
mcp/streamable_client_test.go
View file

@ -119,14 +119,15 @@ func (s *fakeStreamableServer) ServeHTTP(w http.ResponseWriter, req *http.Reques
for k, v := range resp.header {
w.Header().Set(k, v)
}
rc := http.NewResponseController(w)
w.WriteHeader(status)
w.(http.Flusher).Flush() // flush response headers
rc.Flush() // flush response headers
if v := req.Header.Get(protocolVersionHeader); v != resp.wantProtocolVersion && resp.wantProtocolVersion != "" {
s.t.Errorf("%v: bad protocol version header: got %q, want %q", key, v, resp.wantProtocolVersion)
}
w.Write([]byte(body))
w.(http.Flusher).Flush() // flush response
rc.Flush() // flush response
if resp.done != nil {
<-resp.done