modelcontextprotocol/go-sdk
Watch
1
0
Fork
You've already forked go-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

internal/jsonrpc2_v2: fix typos

Browse source 
Change-Id: I96ad3f8fdb675bdb249934d92fd5d01d28c7dd6b
GitHub-Last-Rev: 969dfc7945b6199ee4b28a04c48e8bbe45f4df7b
GitHub-Pull-Request: golang/tools#421
Reviewed-on: https://go-review.googlesource.com/c/tools/+/461075
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
This commit is contained in:
kouler 2023-01-08 13:06:38 +00:00 • committed by Gopher Robot
commit ef64c539fa
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
internal/jsonrpc2/conn.go
View file

@ -156,11 +156,11 @@ func (c *Connection) updateInFlight(f func(*inFlightState)) {
} }
} }
// idle reports whether the connction is in a state with no pending calls or // idle reports whether the connection is in a state with no pending calls or
// notifications. // notifications.
// //
// If idle returns true, the readIncoming goroutine may still be running, // If idle returns true, the readIncoming goroutine may still be running,
// but no other goroutines are doing work on behalf of the connnection. // but no other goroutines are doing work on behalf of the connection.
func (s *inFlightState) idle() bool { func (s *inFlightState) idle() bool {
return len(s.outgoingCalls) == 0 && s.outgoingNotifications == 0 && s.incoming == 0 && !s.handlerRunning return len(s.outgoingCalls) == 0 && s.outgoingNotifications == 0 && s.incoming == 0 && !s.handlerRunning
} }

2
internal/jsonrpc2/serve.go
View file

@ -183,7 +183,7 @@ func (l *idleListener) Accept(ctx context.Context) (io.ReadWriteCloser, error) {
// In theory the timeout could have raced with an unrelated error return // In theory the timeout could have raced with an unrelated error return
// from Accept. However, ErrIdleTimeout is arguably still valid (since we // from Accept. However, ErrIdleTimeout is arguably still valid (since we
// would have closed due to the timeout independent of the error), and the // would have closed due to the timeout independent of the error), and the
// harm from returning a spurious ErrIdleTimeout is negliglible anyway. // harm from returning a spurious ErrIdleTimeout is negligible anyway.
} }
return nil, ErrIdleTimeout return nil, ErrIdleTimeout

4
internal/jsonrpc2/serve_pre116.go
View file

@ -19,10 +19,10 @@ var errClosed = errors.New("use of closed network connection")
// isErrClosed reports whether err ends in the same string as errClosed. // isErrClosed reports whether err ends in the same string as errClosed.
func isErrClosed(err error) bool { func isErrClosed(err error) bool {
// As of Go 1.16, this could be 'errors.Is(err, net.ErrClosing)', but // As of Go 1.16, this could be 'errors.Is(err, net.ErrClosing)', but
// unfortunately gopls still requires compatiblity with // unfortunately gopls still requires compatibility with
// (otherwise-unsupported) older Go versions. // (otherwise-unsupported) older Go versions.
// //
// In the meantime, this error strirng has not changed on any supported Go // In the meantime, this error string has not changed on any supported Go
// version, and is not expected to change in the future. // version, and is not expected to change in the future.
// This is not ideal, but since the worst that could happen here is some // This is not ideal, but since the worst that could happen here is some
// superfluous logging, it is acceptable. // superfluous logging, it is acceptable.