// Copyright 2025 The Go MCP SDK Authors. All rights reserved. // Use of this source code is governed by an MIT-style // license that can be found in the LICENSE file. package mcp import ( "bytes" "context" "errors" "fmt" "io" "log/slog" "net/url" "path/filepath" "runtime" "slices" "strings" "sync" "sync/atomic" "testing" "time" "github.com/google/go-cmp/cmp" "github.com/google/jsonschema-go/jsonschema" "github.com/modelcontextprotocol/go-sdk/internal/jsonrpc2" ) type hiParams struct { Name string } // TODO(jba): after schemas are stateless (WIP), this can be a variable. func greetTool() *Tool { return &Tool{Name: "greet", Description: "say hi"} } func sayHi(ctx context.Context, req *ServerRequest[*CallToolParamsFor[hiParams]]) (*CallToolResultFor[any], error) { if err := req.Session.Ping(ctx, nil); err != nil { return nil, fmt.Errorf("ping failed: %v", err) } return &CallToolResultFor[any]{Content: []Content{&TextContent{Text: "hi " + req.Params.Arguments.Name}}}, nil } var codeReviewPrompt = &Prompt{ Name: "code_review", Description: "do a code review", Arguments: []*PromptArgument{{Name: "Code", Required: true}}, } func codReviewPromptHandler(_ context.Context, _ *ServerSession, params *GetPromptParams) (*GetPromptResult, error) { return &GetPromptResult{ Description: "Code review prompt", Messages: []*PromptMessage{ {Role: "user", Content: &TextContent{Text: "Please review the following code: " + params.Arguments["Code"]}}, }, }, nil } func TestEndToEnd(t *testing.T) { ctx := context.Background() var ct, st Transport = NewInMemoryTransports() // Channels to check if notification callbacks happened. notificationChans := map[string]chan int{} for _, name := range []string{"initialized", "roots", "tools", "prompts", "resources", "progress_server", "progress_client", "resource_updated", "subscribe", "unsubscribe"} { notificationChans[name] = make(chan int, 1) } waitForNotification := func(t *testing.T, name string) { t.Helper() select { case <-notificationChans[name]: case <-time.After(time.Second): t.Fatalf("%s handler never called", name) } } sopts := &ServerOptions{ InitializedHandler: func(context.Context, *ServerRequest[*InitializedParams]) { notificationChans["initialized"] <- 0 }, RootsListChangedHandler: func(context.Context, *ServerRequest[*RootsListChangedParams]) { notificationChans["roots"] <- 0 }, ProgressNotificationHandler: func(context.Context, *ServerRequest[*ProgressNotificationParams]) { notificationChans["progress_server"] <- 0 }, SubscribeHandler: func(context.Context, *ServerRequest[*SubscribeParams]) error { notificationChans["subscribe"] <- 0 return nil }, UnsubscribeHandler: func(context.Context, *ServerRequest[*UnsubscribeParams]) error { notificationChans["unsubscribe"] <- 0 return nil }, } s := NewServer(testImpl, sopts) AddTool(s, &Tool{ Name: "greet", Description: "say hi", }, sayHi) s.AddTool(&Tool{Name: "fail", InputSchema: &jsonschema.Schema{}}, func(context.Context, *ServerRequest[*CallToolParamsFor[map[string]any]]) (*CallToolResult, error) { return nil, errTestFailure }) s.AddPrompt(codeReviewPrompt, codReviewPromptHandler) s.AddPrompt(&Prompt{Name: "fail"}, func(_ context.Context, _ *ServerSession, _ *GetPromptParams) (*GetPromptResult, error) { return nil, errTestFailure }) s.AddResource(resource1, readHandler) s.AddResource(resource2, readHandler) // Connect the server. ss, err := s.Connect(ctx, st, nil) if err != nil { t.Fatal(err) } if got := slices.Collect(s.Sessions()); len(got) != 1 { t.Errorf("after connection, Clients() has length %d, want 1", len(got)) } // Wait for the server to exit after the client closes its connection. var clientWG sync.WaitGroup clientWG.Add(1) go func() { if err := ss.Wait(); err != nil { t.Errorf("server failed: %v", err) } clientWG.Done() }() loggingMessages := make(chan *LoggingMessageParams, 100) // big enough for all logging opts := &ClientOptions{ CreateMessageHandler: func(context.Context, *ClientRequest[*CreateMessageParams]) (*CreateMessageResult, error) { return &CreateMessageResult{Model: "aModel", Content: &TextContent{}}, nil }, ToolListChangedHandler: func(context.Context, *ClientRequest[*ToolListChangedParams]) { notificationChans["tools"] <- 0 }, PromptListChangedHandler: func(context.Context, *ClientRequest[*PromptListChangedParams]) { notificationChans["prompts"] <- 0 }, ResourceListChangedHandler: func(context.Context, *ClientRequest[*ResourceListChangedParams]) { notificationChans["resources"] <- 0 }, LoggingMessageHandler: func(_ context.Context, req *ClientRequest[*LoggingMessageParams]) { loggingMessages <- req.Params }, ProgressNotificationHandler: func(context.Context, *ClientRequest[*ProgressNotificationParams]) { notificationChans["progress_client"] <- 0 }, ResourceUpdatedHandler: func(context.Context, *ClientRequest[*ResourceUpdatedNotificationParams]) { notificationChans["resource_updated"] <- 0 }, } c := NewClient(testImpl, opts) rootAbs, err := filepath.Abs(filepath.FromSlash("testdata/files")) if err != nil { t.Fatal(err) } c.AddRoots(&Root{URI: "file://" + rootAbs}) // Connect the client. cs, err := c.Connect(ctx, ct, nil) if err != nil { t.Fatal(err) } waitForNotification(t, "initialized") if err := cs.Ping(ctx, nil); err != nil { t.Fatalf("ping failed: %v", err) } t.Run("prompts", func(t *testing.T) { res, err := cs.ListPrompts(ctx, nil) if err != nil { t.Fatalf("prompts/list failed: %v", err) } wantPrompts := []*Prompt{ { Name: "code_review", Description: "do a code review", Arguments: []*PromptArgument{{Name: "Code", Required: true}}, }, {Name: "fail"}, } if diff := cmp.Diff(wantPrompts, res.Prompts); diff != "" { t.Fatalf("prompts/list mismatch (-want +got):\n%s", diff) } gotReview, err := cs.GetPrompt(ctx, &GetPromptParams{Name: "code_review", Arguments: map[string]string{"Code": "1+1"}}) if err != nil { t.Fatal(err) } wantReview := &GetPromptResult{ Description: "Code review prompt", Messages: []*PromptMessage{{ Content: &TextContent{Text: "Please review the following code: 1+1"}, Role: "user", }}, } if diff := cmp.Diff(wantReview, gotReview); diff != "" { t.Errorf("prompts/get 'code_review' mismatch (-want +got):\n%s", diff) } if _, err := cs.GetPrompt(ctx, &GetPromptParams{Name: "fail"}); err == nil || !strings.Contains(err.Error(), errTestFailure.Error()) { t.Errorf("fail returned unexpected error: got %v, want containing %v", err, errTestFailure) } s.AddPrompt(&Prompt{Name: "T"}, nil) waitForNotification(t, "prompts") s.RemovePrompts("T") waitForNotification(t, "prompts") }) t.Run("tools", func(t *testing.T) { // ListTools is tested in client_list_test.go. gotHi, err := cs.CallTool(ctx, &CallToolParams{ Name: "greet", Arguments: map[string]any{"name": "user"}, }) if err != nil { t.Fatal(err) } wantHi := &CallToolResult{ Content: []Content{ &TextContent{Text: "hi user"}, }, } if diff := cmp.Diff(wantHi, gotHi); diff != "" { t.Errorf("tools/call 'greet' mismatch (-want +got):\n%s", diff) } gotFail, err := cs.CallTool(ctx, &CallToolParams{ Name: "fail", Arguments: map[string]any{}, }) // Counter-intuitively, when a tool fails, we don't expect an RPC error for // call tool: instead, the failure is embedded in the result. if err != nil { t.Fatal(err) } wantFail := &CallToolResult{ IsError: true, Content: []Content{ &TextContent{Text: errTestFailure.Error()}, }, } if diff := cmp.Diff(wantFail, gotFail); diff != "" { t.Errorf("tools/call 'fail' mismatch (-want +got):\n%s", diff) } s.AddTool(&Tool{Name: "T", InputSchema: &jsonschema.Schema{}}, nopHandler) waitForNotification(t, "tools") s.RemoveTools("T") waitForNotification(t, "tools") }) t.Run("resources", func(t *testing.T) { if runtime.GOOS == "windows" { t.Skip("TODO: fix for Windows") } wantResources := []*Resource{resource2, resource1} lrres, err := cs.ListResources(ctx, nil) if err != nil { t.Fatal(err) } if diff := cmp.Diff(wantResources, lrres.Resources); diff != "" { t.Errorf("resources/list mismatch (-want, +got):\n%s", diff) } template := &ResourceTemplate{ Name: "rt", MIMEType: "text/template", URITemplate: "file:///{+filename}", // the '+' means that filename can contain '/' } s.AddResourceTemplate(template, readHandler) tres, err := cs.ListResourceTemplates(ctx, nil) if err != nil { t.Fatal(err) } if diff := cmp.Diff([]*ResourceTemplate{template}, tres.ResourceTemplates); diff != "" { t.Errorf("resources/list mismatch (-want, +got):\n%s", diff) } for _, tt := range []struct { uri string mimeType string // "": not found; "text/plain": resource; "text/template": template fail bool // non-nil error returned }{ {"file:///info.txt", "text/plain", false}, {"file:///fail.txt", "", false}, {"file:///template.txt", "text/template", false}, {"file:///../private.txt", "", true}, // not found: escaping disallowed } { rres, err := cs.ReadResource(ctx, &ReadResourceParams{URI: tt.uri}) if err != nil { if code := errorCode(err); code == CodeResourceNotFound { if tt.mimeType != "" { t.Errorf("%s: not found but expected it to be", tt.uri) } } else if !tt.fail { t.Errorf("%s: unexpected error %v", tt.uri, err) } } else { if tt.fail { t.Errorf("%s: unexpected success", tt.uri) } else if g, w := len(rres.Contents), 1; g != w { t.Errorf("got %d contents, wanted %d", g, w) } else { c := rres.Contents[0] if got := c.URI; got != tt.uri { t.Errorf("got uri %q, want %q", got, tt.uri) } if got := c.MIMEType; got != tt.mimeType { t.Errorf("%s: got MIME type %q, want %q", tt.uri, got, tt.mimeType) } } } } s.AddResource(&Resource{URI: "http://U"}, nil) waitForNotification(t, "resources") s.RemoveResources("http://U") waitForNotification(t, "resources") }) t.Run("roots", func(t *testing.T) { rootRes, err := ss.ListRoots(ctx, &ListRootsParams{}) if err != nil { t.Fatal(err) } gotRoots := rootRes.Roots wantRoots := slices.Collect(c.roots.all()) if diff := cmp.Diff(wantRoots, gotRoots); diff != "" { t.Errorf("roots/list mismatch (-want +got):\n%s", diff) } c.AddRoots(&Root{URI: "U"}) waitForNotification(t, "roots") c.RemoveRoots("U") waitForNotification(t, "roots") }) t.Run("sampling", func(t *testing.T) { // TODO: test that a client that doesn't have the handler returns CodeUnsupportedMethod. res, err := ss.CreateMessage(ctx, &CreateMessageParams{}) if err != nil { t.Fatal(err) } if g, w := res.Model, "aModel"; g != w { t.Errorf("got %q, want %q", g, w) } }) t.Run("logging", func(t *testing.T) { want := []*LoggingMessageParams{ { Logger: "test", Level: "warning", Data: map[string]any{ "msg": "first", "name": "Pat", "logtest": true, }, }, { Logger: "test", Level: "alert", Data: map[string]any{ "msg": "second", "count": 2.0, "logtest": true, }, }, } check := func(t *testing.T) { t.Helper() var got []*LoggingMessageParams // Read messages from this test until we've seen all we expect. for len(got) < len(want) { select { case p := <-loggingMessages: // Ignore logging from other tests. if m, ok := p.Data.(map[string]any); ok && m["logtest"] != nil { delete(m, "time") // remove time because it changes got = append(got, p) } case <-time.After(time.Second): t.Fatal("timed out waiting for log messages") } } if diff := cmp.Diff(want, got); diff != "" { t.Errorf("mismatch (-want, +got):\n%s", diff) } } t.Run("direct", func(t *testing.T) { // Use the LoggingMessage method directly. mustLog := func(level LoggingLevel, data any) { t.Helper() if err := ss.Log(ctx, &LoggingMessageParams{ Logger: "test", Level: level, Data: data, }); err != nil { t.Fatal(err) } } // Nothing should be logged until the client sets a level. mustLog("info", "before") if err := cs.SetLoggingLevel(ctx, &SetLoggingLevelParams{Level: "warning"}); err != nil { t.Fatal(err) } mustLog("warning", want[0].Data) mustLog("debug", "nope") // below the level mustLog("info", "negative") // below the level mustLog("alert", want[1].Data) check(t) }) t.Run("handler", func(t *testing.T) { // Use the slog handler. // We can't check the "before SetLevel" behavior because it's already been set. // Not a big deal: that check is in LoggingMessage anyway. logger := slog.New(NewLoggingHandler(ss, &LoggingHandlerOptions{LoggerName: "test"})) logger.Warn("first", "name", "Pat", "logtest", true) logger.Debug("nope") // below the level logger.Info("negative") // below the level logger.Log(ctx, LevelAlert, "second", "count", 2, "logtest", true) check(t) }) }) t.Run("progress", func(t *testing.T) { ss.NotifyProgress(ctx, &ProgressNotificationParams{ ProgressToken: "token-xyz", Message: "progress update", Progress: 0.5, Total: 2, }) waitForNotification(t, "progress_client") cs.NotifyProgress(ctx, &ProgressNotificationParams{ ProgressToken: "token-abc", Message: "progress update", Progress: 1, Total: 2, }) waitForNotification(t, "progress_server") }) t.Run("resource_subscriptions", func(t *testing.T) { err := cs.Subscribe(ctx, &SubscribeParams{ URI: "test", }) if err != nil { t.Fatal(err) } waitForNotification(t, "subscribe") s.ResourceUpdated(ctx, &ResourceUpdatedNotificationParams{ URI: "test", }) waitForNotification(t, "resource_updated") err = cs.Unsubscribe(ctx, &UnsubscribeParams{ URI: "test", }) if err != nil { t.Fatal(err) } waitForNotification(t, "unsubscribe") // Verify the client does not receive the update after unsubscribing. s.ResourceUpdated(ctx, &ResourceUpdatedNotificationParams{ URI: "test", }) select { case <-notificationChans["resource_updated"]: t.Fatalf("resource updated after unsubscription") case <-time.After(time.Second): } }) // Disconnect. cs.Close() clientWG.Wait() // After disconnecting, neither client nor server should have any // connections. for range s.Sessions() { t.Errorf("unexpected client after disconnection") } } // Registry of values to be referenced in tests. var ( errTestFailure = errors.New("mcp failure") resource1 = &Resource{ Name: "public", MIMEType: "text/plain", URI: "file:///info.txt", } resource2 = &Resource{ Name: "public", // names are not unique IDs MIMEType: "text/plain", URI: "file:///fail.txt", } resource3 = &Resource{ Name: "info", MIMEType: "text/plain", URI: "embedded:info", } readHandler = fileResourceHandler("testdata/files") ) var embeddedResources = map[string]string{ "info": "This is the MCP test server.", } func handleEmbeddedResource(_ context.Context, req *ServerRequest[*ReadResourceParams]) (*ReadResourceResult, error) { u, err := url.Parse(req.Params.URI) if err != nil { return nil, err } if u.Scheme != "embedded" { return nil, fmt.Errorf("wrong scheme: %q", u.Scheme) } key := u.Opaque text, ok := embeddedResources[key] if !ok { return nil, fmt.Errorf("no embedded resource named %q", key) } return &ReadResourceResult{ Contents: []*ResourceContents{ {URI: req.Params.URI, MIMEType: "text/plain", Text: text}, }, }, nil } // errorCode returns the code associated with err. // If err is nil, it returns 0. // If there is no code, it returns -1. func errorCode(err error) int64 { if err == nil { return 0 } var werr *jsonrpc2.WireError if errors.As(err, &werr) { return werr.Code } return -1 } // basicConnection returns a new basic client-server connection, with the server // configured via the provided function. // // The caller should cancel either the client connection or server connection // when the connections are no longer needed. func basicConnection(t *testing.T, config func(*Server)) (*ClientSession, *ServerSession) { return basicClientServerConnection(t, nil, nil, config) } // basicClientServerConnection creates a basic connection between client and // server. If either client or server is nil, empty implementations are used. // // The provided function may be used to configure features on the resulting // server, prior to connection. // // The caller should cancel either the client connection or server connection // when the connections are no longer needed. func basicClientServerConnection(t *testing.T, client *Client, server *Server, config func(*Server)) (*ClientSession, *ServerSession) { t.Helper() ctx := context.Background() ct, st := NewInMemoryTransports() if server == nil { server = NewServer(testImpl, nil) } if config != nil { config(server) } ss, err := server.Connect(ctx, st, nil) if err != nil { t.Fatal(err) } if client == nil { client = NewClient(testImpl, nil) } cs, err := client.Connect(ctx, ct, nil) if err != nil { t.Fatal(err) } return cs, ss } func TestServerClosing(t *testing.T) { cs, ss := basicConnection(t, func(s *Server) { AddTool(s, greetTool(), sayHi) }) defer cs.Close() ctx := context.Background() var wg sync.WaitGroup wg.Add(1) go func() { if err := cs.Wait(); err != nil { t.Errorf("server connection failed: %v", err) } wg.Done() }() if _, err := cs.CallTool(ctx, &CallToolParams{ Name: "greet", Arguments: map[string]any{"name": "user"}, }); err != nil { t.Fatalf("after connecting: %v", err) } ss.Close() wg.Wait() if _, err := cs.CallTool(ctx, &CallToolParams{ Name: "greet", Arguments: map[string]any{"name": "user"}, }); !errors.Is(err, ErrConnectionClosed) { t.Errorf("after disconnection, got error %v, want EOF", err) } } func TestBatching(t *testing.T) { ctx := context.Background() ct, st := NewInMemoryTransports() s := NewServer(testImpl, nil) _, err := s.Connect(ctx, st, nil) if err != nil { t.Fatal(err) } c := NewClient(testImpl, nil) // TODO: this test is broken, because increasing the batch size here causes // 'initialize' to block. Therefore, we can only test with a size of 1. // Since batching is being removed, we can probably just delete this. const batchSize = 1 cs, err := c.Connect(ctx, ct, nil) if err != nil { t.Fatal(err) } defer cs.Close() errs := make(chan error, batchSize) for i := range batchSize { go func() { _, err := cs.ListTools(ctx, nil) errs <- err }() time.Sleep(2 * time.Millisecond) if i < batchSize-1 { select { case <-errs: t.Errorf("ListTools: unexpected result for incomplete batch: %v", err) default: } } } } func TestCancellation(t *testing.T) { var ( start = make(chan struct{}) cancelled = make(chan struct{}, 1) // don't block the request ) slowRequest := func(ctx context.Context, req *ServerRequest[*CallToolParams]) (*CallToolResult, error) { start <- struct{}{} select { case <-ctx.Done(): cancelled <- struct{}{} case <-time.After(5 * time.Second): return nil, nil } return nil, nil } cs, _ := basicConnection(t, func(s *Server) { AddTool(s, &Tool{Name: "slow"}, slowRequest) }) defer cs.Close() ctx, cancel := context.WithCancel(context.Background()) go cs.CallTool(ctx, &CallToolParams{Name: "slow"}) <-start cancel() select { case <-cancelled: case <-time.After(5 * time.Second): t.Fatal("timeout waiting for cancellation") } } func TestMiddleware(t *testing.T) { ctx := context.Background() ct, st := NewInMemoryTransports() s := NewServer(testImpl, nil) ss, err := s.Connect(ctx, st, nil) if err != nil { t.Fatal(err) } // Wait for the server to exit after the client closes its connection. var clientWG sync.WaitGroup clientWG.Add(1) go func() { if err := ss.Wait(); err != nil { t.Errorf("server failed: %v", err) } clientWG.Done() }() var sbuf, cbuf bytes.Buffer sbuf.WriteByte('\n') cbuf.WriteByte('\n') // "1" is the outer middleware layer, called first; then "2" is called, and finally // the default dispatcher. s.AddSendingMiddleware(traceCalls[*ServerSession](&sbuf, "S1"), traceCalls[*ServerSession](&sbuf, "S2")) s.AddReceivingMiddleware(traceCalls[*ServerSession](&sbuf, "R1"), traceCalls[*ServerSession](&sbuf, "R2")) c := NewClient(testImpl, nil) c.AddSendingMiddleware(traceCalls[*ClientSession](&cbuf, "S1"), traceCalls[*ClientSession](&cbuf, "S2")) c.AddReceivingMiddleware(traceCalls[*ClientSession](&cbuf, "R1"), traceCalls[*ClientSession](&cbuf, "R2")) cs, err := c.Connect(ctx, ct, nil) if err != nil { t.Fatal(err) } if _, err := cs.ListTools(ctx, nil); err != nil { t.Fatal(err) } if _, err := ss.ListRoots(ctx, nil); err != nil { t.Fatal(err) } wantServer := ` R1 >initialize R2 >initialize R2 notifications/initialized R2 >notifications/initialized R2 tools/list R2 >tools/list R2 roots/list S2 >roots/list S2 initialize S2 >initialize S2 notifications/initialized S2 >notifications/initialized S2 tools/list S2 >tools/list S2 roots/list R2 >roots/list R2 = 0 { start := max(i-20, 0) end := min(i+20, len(logs)) t.Errorf("conformance violation: MCP logs contain JSON null: %s", "..."+string(logs[start:end])+"...") } } // traceCalls creates a middleware function that prints the method before and after each call // with the given prefix. func traceCalls[S Session](w io.Writer, prefix string) Middleware { return func(h MethodHandler) MethodHandler { return func(ctx context.Context, method string, req Request) (Result, error) { fmt.Fprintf(w, "%s >%s\n", prefix, method) defer fmt.Fprintf(w, "%s <%s\n", prefix, method) return h(ctx, method, req) } } } func nopHandler(context.Context, *ServerRequest[*CallToolParamsFor[map[string]any]]) (*CallToolResult, error) { return nil, nil } func TestKeepAlive(t *testing.T) { // TODO: try to use the new synctest package for this test once we upgrade to Go 1.24+. // synctest would allow us to control time and avoid the time.Sleep calls, making the test // faster and more deterministic. ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) defer cancel() ct, st := NewInMemoryTransports() serverOpts := &ServerOptions{ KeepAlive: 100 * time.Millisecond, } s := NewServer(testImpl, serverOpts) AddTool(s, greetTool(), sayHi) ss, err := s.Connect(ctx, st, nil) if err != nil { t.Fatal(err) } defer ss.Close() clientOpts := &ClientOptions{ KeepAlive: 100 * time.Millisecond, } c := NewClient(testImpl, clientOpts) cs, err := c.Connect(ctx, ct, nil) if err != nil { t.Fatal(err) } defer cs.Close() // Wait for a few keepalive cycles to ensure pings are working time.Sleep(300 * time.Millisecond) // Test that the connection is still alive by making a call result, err := cs.CallTool(ctx, &CallToolParams{ Name: "greet", Arguments: map[string]any{"Name": "user"}, }) if err != nil { t.Fatalf("call failed after keepalive: %v", err) } if len(result.Content) == 0 { t.Fatal("expected content in result") } if textContent, ok := result.Content[0].(*TextContent); !ok || textContent.Text != "hi user" { t.Fatalf("unexpected result: %v", result.Content[0]) } } func TestKeepAliveFailure(t *testing.T) { ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) defer cancel() ct, st := NewInMemoryTransports() // Server without keepalive (to test one-sided keepalive) s := NewServer(testImpl, nil) AddTool(s, greetTool(), sayHi) ss, err := s.Connect(ctx, st, nil) if err != nil { t.Fatal(err) } // Client with short keepalive clientOpts := &ClientOptions{ KeepAlive: 50 * time.Millisecond, } c := NewClient(testImpl, clientOpts) cs, err := c.Connect(ctx, ct, nil) if err != nil { t.Fatal(err) } defer cs.Close() // Let the connection establish properly first time.Sleep(30 * time.Millisecond) // simulate ping failure ss.Close() // Wait for keepalive to detect the failure and close the client // check periodically instead of just waiting deadline := time.Now().Add(1 * time.Second) for time.Now().Before(deadline) { _, err = cs.CallTool(ctx, &CallToolParams{ Name: "greet", Arguments: map[string]any{"Name": "user"}, }) if errors.Is(err, ErrConnectionClosed) { return // Test passed } time.Sleep(25 * time.Millisecond) } t.Errorf("expected connection to be closed by keepalive, but it wasn't. Last error: %v", err) } func TestAddTool_DuplicateNoPanicAndNoDuplicate(t *testing.T) { // Adding the same tool pointer twice should not panic and should not // produce duplicates in the server's tool list. cs, _ := basicConnection(t, func(s *Server) { // Use two distinct Tool instances with the same name but different // descriptions to ensure the second replaces the first // This case was written specifically to reproduce a bug where duplicate tools where causing jsonschema errors t1 := &Tool{Name: "dup", Description: "first", InputSchema: &jsonschema.Schema{}} t2 := &Tool{Name: "dup", Description: "second", InputSchema: &jsonschema.Schema{}} s.AddTool(t1, nopHandler) s.AddTool(t2, nopHandler) }) defer cs.Close() ctx := context.Background() res, err := cs.ListTools(ctx, nil) if err != nil { t.Fatal(err) } var count int var gotDesc string for _, tt := range res.Tools { if tt.Name == "dup" { count++ gotDesc = tt.Description } } if count != 1 { t.Fatalf("expected exactly one 'dup' tool, got %d", count) } if gotDesc != "second" { t.Fatalf("expected replaced tool to have description %q, got %q", "second", gotDesc) } } func TestSynchronousNotifications(t *testing.T) { var toolsChanged atomic.Bool clientOpts := &ClientOptions{ ToolListChangedHandler: func(ctx context.Context, req *ClientRequest[*ToolListChangedParams]) { toolsChanged.Store(true) }, CreateMessageHandler: func(ctx context.Context, req *ClientRequest[*CreateMessageParams]) (*CreateMessageResult, error) { if !toolsChanged.Load() { return nil, fmt.Errorf("didn't get a tools changed notification") } // TODO(rfindley): investigate the error returned from this test if // CreateMessageResult is new(CreateMessageResult): it's a mysterious // unmarshalling error that we should improve. return &CreateMessageResult{Content: &TextContent{}}, nil }, } client := NewClient(testImpl, clientOpts) var rootsChanged atomic.Bool serverOpts := &ServerOptions{ RootsListChangedHandler: func(_ context.Context, req *ServerRequest[*RootsListChangedParams]) { rootsChanged.Store(true) }, } server := NewServer(testImpl, serverOpts) cs, ss := basicClientServerConnection(t, client, server, func(s *Server) { AddTool(s, &Tool{Name: "tool"}, func(ctx context.Context, req *ServerRequest[*CallToolParams]) (*CallToolResult, error) { if !rootsChanged.Load() { return nil, fmt.Errorf("didn't get root change notification") } return new(CallToolResult), nil }) }) t.Run("from client", func(t *testing.T) { client.AddRoots(&Root{Name: "myroot", URI: "file://foo"}) res, err := cs.CallTool(context.Background(), &CallToolParams{Name: "tool"}) if err != nil { t.Fatalf("CallTool failed: %v", err) } if res.IsError { t.Errorf("tool error: %v", res.Content[0].(*TextContent).Text) } }) t.Run("from server", func(t *testing.T) { server.RemoveTools("tool") if _, err := ss.CreateMessage(context.Background(), new(CreateMessageParams)); err != nil { t.Errorf("CreateMessage failed: %v", err) } }) } func TestNoDistributedDeadlock(t *testing.T) { // This test verifies that calls are asynchronous, and so it's not possible // to have a distributed deadlock. // // The setup creates potential deadlock for both the client and server: the // client sends a call to tool1, which itself calls createMessage, which in // turn calls tool2, which calls ping. // // If the server were not asynchronous, the call to tool2 would hang. If the // client were not asynchronous, the call to ping would hang. // // Such a scenario is unlikely in practice, but is still theoretically // possible, and in any case making tool calls asynchronous by default // delegates synchronization to the user. clientOpts := &ClientOptions{ CreateMessageHandler: func(ctx context.Context, req *ClientRequest[*CreateMessageParams]) (*CreateMessageResult, error) { req.Session.CallTool(ctx, &CallToolParams{Name: "tool2"}) return &CreateMessageResult{Content: &TextContent{}}, nil }, } client := NewClient(testImpl, clientOpts) cs, _ := basicClientServerConnection(t, client, nil, func(s *Server) { AddTool(s, &Tool{Name: "tool1"}, func(ctx context.Context, req *ServerRequest[*CallToolParams]) (*CallToolResult, error) { req.Session.CreateMessage(ctx, new(CreateMessageParams)) return new(CallToolResult), nil }) AddTool(s, &Tool{Name: "tool2"}, func(ctx context.Context, req *ServerRequest[*CallToolParams]) (*CallToolResult, error) { req.Session.Ping(ctx, nil) return new(CallToolResult), nil }) }) defer cs.Close() ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) defer cancel() if _, err := cs.CallTool(ctx, &CallToolParams{Name: "tool1"}); err != nil { // should not deadlock t.Fatalf("CallTool failed: %v", err) } } var testImpl = &Implementation{Name: "test", Version: "v1.0.0"}