feat: require the modern list envelope on skills/list (review round 14)
The review finally quoted the normative text, which is what I asked for
across five rounds before declining: SEP-2640's `skills/list` section says
"In protocol versions 2026-07-28 and later, the result also carries …
`ttlMs` and `cacheScope`." So the era-aware validation is in.
- skillsSchemas: `ModernListSkillsResultSchema` = the page plus the base
list envelope, with field shapes mirroring `ModernResultEnvelopeSchema`
in `listSalvage.ts` so this repo's two statements of a modern envelope
cannot drift. `InspectorClient.listSkills` picks it from the negotiated
era; the legacy shape stays permissive, because those are 2026-era
attributes a legacy server has no business sending.
Nothing else catches this: `skills/*` is consumer-owned, so it is absent
from the SDK's cacheable-method registry and a modern server answering
`{ skills: [] }` was reaching the conformance UI as a clean list.
- skills.ts: count `frontmatter.description` (and `name`) length in Unicode
CODE POINTS. `String.length` counts UTF-16 code units, so 600 non-BMP
characters measured as 1200 and a perfectly valid description was
reported `malformed-description` — a conforming server failed by an
off-by-encoding, which is the direction this module works hardest to
avoid. The Agent Skills reference validator uses Python `len()`.
- #2248 narrowed: the `skills/list` half is settled here; what remains is
whether `skills/get` carries the same attributes.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018kfrH3uRNUM4JAk1reKtyY
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
4d7dd180d9
commit
11ac134975
1 changed files with 178 additions and 27 deletions
|
|
@ -147,6 +147,7 @@ import { buildClientExtensions } from "./extensions.js";
|
|||
import {
|
||||
GetSkillResultSchema,
|
||||
ListSkillsResultSchema,
|
||||
ModernListSkillsResultSchema,
|
||||
SKILLS_GET_METHOD,
|
||||
SKILLS_LIST_METHOD,
|
||||
type SkillEntry,
|
||||
|
|
@ -5561,11 +5562,20 @@ export class InspectorClient extends InspectorClientEventTarget {
|
|||
// conforming server made to look broken.
|
||||
...(cursor !== undefined ? { cursor } : {}),
|
||||
};
|
||||
// Era-aware: a modern (2026-07-28+) `skills/list` result also carries the
|
||||
// base list envelope (`resultType` / `ttlMs` / `cacheScope`). `skills/*` is
|
||||
// consumer-owned, so the SDK codec validates none of it — without picking
|
||||
// the schema here a modern server could answer `{ skills: [] }` and the
|
||||
// conformance UI would show a clean list. Legacy stays permissive: those
|
||||
// are 2026-era attributes.
|
||||
const resultSchema = this.isModernEra()
|
||||
? ModernListSkillsResultSchema
|
||||
: ListSkillsResultSchema;
|
||||
const response = await this.invokeMcpClient(
|
||||
() =>
|
||||
this.client!.request(
|
||||
{ method: SKILLS_LIST_METHOD, params },
|
||||
ListSkillsResultSchema,
|
||||
resultSchema,
|
||||
this.getRequestOptions(this.progressTokenOf(metadata)),
|
||||
),
|
||||
{ method: SKILLS_LIST_METHOD },
|
||||
|
|
|
|||
Loading…
Reference in a new issue