fix(web): list refreshInitialConfig in both persist callbacks' deps
Both `useCallback`s that wrap a persist call in `refreshingPersist` captured `refreshInitialConfig` without listing it. `useInitialConfig`'s `refresh` is not referentially stable — it is a `useCallback` over `load`, whose deps are `[base, authToken, doFetch]` — so once any of those changes, the pagination save and the server removal keep invoking the obsolete closure and the secret-storage footer can go stale. `react-hooks/exhaustive-deps` reported both, but the rule is warn-level and `lint` does not fail on warnings, so `npm run ci` stayed green. These two were the only warnings in the entire web client. Closes #1950 (review round 25) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JTHVxSu8AUgHRLvo1ntZ8H Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
af3d940e78
commit
1202bd8663
1 changed files with 2 additions and 0 deletions
|
|
@ -3651,6 +3651,7 @@ function App() {
|
|||
activeServerId,
|
||||
inspectorClient,
|
||||
updateServerSettings,
|
||||
refreshInitialConfig,
|
||||
connected,
|
||||
loadToolsPage,
|
||||
loadPromptsPage,
|
||||
|
|
@ -3921,6 +3922,7 @@ function App() {
|
|||
fetchRequestLogState,
|
||||
stderrLogState,
|
||||
removeServer,
|
||||
refreshInitialConfig,
|
||||
]);
|
||||
|
||||
// Submit handler for the Add / Edit / Clone modal. Add and Clone both go
|
||||
|
|
|
|||
Loading…
Reference in a new issue