Guided-auth removal, OAuth smoke testing, and TUI/CLI support (#1531)

* refactor(web): update OAuth E2E tests to use new authentication method

- Replaced `runGuidedAuth` with `authenticate` in the InspectorClient OAuth end-to-end tests to support quick authentication with CIMD pre-registration.
- Updated comments to reflect the change in authentication method and its support for HTTP test metadata URLs.
- Ensured that the tests continue to validate the expected authorization URL after the change.

Additionally, imported `ensureCimdClientRegistration` in the OAuthManager to streamline client registration during the authentication process.

* Guided-auth removal, OAuth smoke testing, and TUI/CLI support

* Added CLI OAuth runner flags tests

* Added clarifying comment on port 0 binding

* README notes on TUI oauth callback port, prettier fixes for CLI tests

* CIMD validation uses inline like EMA IdP

* Fixed TUI test failures from merge

* test: bring 5 OAuth files over the 90 per-file coverage gate

The guided-auth-removal work added/touched several files that fell below
the repo's >=90 per-file coverage gate (npm run coverage). CI doesn't run
the gate (it's local-only), so validate + test:integration passed while
these gaps slipped through. Bring them all back over the line:

- core/auth/node/runner-oauth-callback.ts: test bad-URL/non-http-scheme
  throws, no-port->80 default, and IPv6 hostname bracketing. Annotate the
  provably-dead guards (empty host, out-of-range port, String(err)
  fallback, pathname "/" fallback) -- all rejected by new URL() upstream --
  with justified v8 ignore comments instead of lowering the gate.
- core/auth/cimd.ts: test the AS-doesn't-support-CIMD early return.
- core/react/useClientSettingsDraft.ts: test the functional-updater path,
  the stale-onChange-after-close prev===null guard, and the
  timer-fires-after-close value===null guard.
- ClientSettingsForm.tsx: test the CIMD checkbox toggle and CIMD URL clear.
- clients/tui/src/utils/oauthDisplay.ts: test static/dcr registration
  kinds, the expired IdP session, and the configured-scope/empty-scope
  branches of formatScopes.

npm run coverage now passes (exit 0) across web, cli, tui, launcher.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: cliffhall <cliff@futurescale.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bob Dickinson 2026-06-29 12:35:51 -07:00 • committed by GitHub
commit 13dafe457b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -21,7 +21,7 @@ describe("loadTuiServers", () => {
rmSync(tempDir, { recursive: true, force: true });
});
it("loads named servers from a read-only --config file", () => {
it("loads named servers from a read-only --config file", async () => {
const configPath = join(tempDir, "mcp.json");
writeFileSync(
configPath,
@ -29,7 +29,7 @@ describe("loadTuiServers", () => {
mcpServers: { foo: { command: "node", args: ["foo.js"] } },
}),
);
const servers = loadTuiServers({ configPath });
const servers = await loadTuiServers({ configPath });
expect(Object.keys(servers)).toEqual(["foo"]);
expect(servers.foo?.config).toMatchObject({
type: "stdio",
@ -37,9 +37,9 @@ describe("loadTuiServers", () => {
});
});
it("seeds an empty writable catalog when --catalog is missing", () => {
it("seeds an empty writable catalog when --catalog is missing", async () => {
const catalogPath = join(tempDir, "catalog.json");
const servers = loadTuiServers({ catalogPath });
const servers = await loadTuiServers({ catalogPath });
expect(servers).toEqual({});
expect(existsSync(catalogPath)).toBe(true);
expect(JSON.parse(readFileSync(catalogPath, "utf-8"))).toEqual({
@ -47,34 +47,34 @@ describe("loadTuiServers", () => {
});
});
it("throws when a read-only --config file is missing (never seeds)", () => {
it("throws when a read-only --config file is missing (never seeds)", async () => {
const configPath = join(tempDir, "absent.json");
expect(() => loadTuiServers({ configPath })).toThrow(
await expect(loadTuiServers({ configPath })).rejects.toThrow(
/Config file not found/,
);
expect(existsSync(configPath)).toBe(false);
});
it("rejects --catalog and --config together", () => {
it("rejects --catalog and --config together", async () => {
const catalogPath = join(tempDir, "catalog.json");
const configPath = join(tempDir, "config.json");
writeFileSync(catalogPath, JSON.stringify({ mcpServers: {} }));
writeFileSync(configPath, JSON.stringify({ mcpServers: {} }));
expect(() => loadTuiServers({ catalogPath, configPath })).toThrow(
await expect(loadTuiServers({ catalogPath, configPath })).rejects.toThrow(
/mutually exclusive/,
);
});
it("rejects --catalog combined with an ad-hoc target", () => {
it("rejects --catalog combined with an ad-hoc target", async () => {
const catalogPath = join(tempDir, "catalog.json");
writeFileSync(catalogPath, JSON.stringify({ mcpServers: {} }));
expect(() =>
await expect(
loadTuiServers({ catalogPath, target: ["my-server"] }),
).toThrow(/--catalog cannot be combined/);
).rejects.toThrow(/--catalog cannot be combined/);
});
it("builds a single ad-hoc server from a positional target", () => {
const servers = loadTuiServers({ target: ["my-server", "--flag"] });
it("builds a single ad-hoc server from a positional target", async () => {
const servers = await loadTuiServers({ target: ["my-server", "--flag"] });
expect(Object.keys(servers)).toEqual(["default"]);
expect(servers.default?.config).toMatchObject({
type: "stdio",
@ -83,7 +83,7 @@ describe("loadTuiServers", () => {
});
});
it("merges --header into per-server settings for catalog servers", () => {
it("merges --header into per-server settings for catalog servers", async () => {
const catalogPath = join(tempDir, "catalog.json");
writeFileSync(
catalogPath,
@ -91,7 +91,7 @@ describe("loadTuiServers", () => {
mcpServers: { web: { type: "streamable-http", url: "http://x/mcp" } },
}),
);
const servers = loadTuiServers({
const servers = await loadTuiServers({
catalogPath,
headers: { Authorization: "Bearer t" },
});