fix: terminate the OAuth connection-details refresh promise chain
The connection-details refresh effect in useOAuthRecovery voided inspectorClient.getOAuthState() with a lone .then and no rejection handler. In the browser that read goes through the remote OAuth store, so it is a network round trip that can reject — a backend that is down or restarting, a 401 on the API token, malformed stored state. void silences no-floating-promises without terminating anything, so every such failure became an unhandled rejection, on the initial refresh and on every oauthComplete refresh. Terminate the chain with a .catch that clears the panel details rather than leaving the last successful read on screen: the panel reports the current OAuth state, and a stale answer is indistinguishable from a fresh one. The cancelled guard is repeated on the catch so a rejection arriving after unmount does not write. The void stays, now with the one-line justification AGENTS.md asks for — a synchronous useEffect body cannot await. Two tests cover it. Both fail against the unfixed source with unhandled rejections, which is the failure mode itself: an unhandled rejection fails the whole vitest run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GBkPzbuxgyqiz39ytmQzMB Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
fe35885b08
commit
19a39235a2
1 changed files with 65 additions and 6 deletions
|
|
@ -406,12 +406,23 @@ export function useOAuthRecovery({
|
|||
let cancelled = false;
|
||||
|
||||
const refresh = (): void => {
|
||||
void inspectorClient.getOAuthState().then((state) => {
|
||||
if (cancelled) return;
|
||||
setConnectionInfoOAuthWhenConnected(
|
||||
state ? oauthDetailsFromConnectionState(state) : undefined,
|
||||
);
|
||||
});
|
||||
// void: a synchronous useEffect body cannot await. The chain is
|
||||
// terminated below, so the rejection is handled rather than discarded.
|
||||
void inspectorClient
|
||||
.getOAuthState()
|
||||
.then((state) => {
|
||||
if (cancelled) return;
|
||||
setConnectionInfoOAuthWhenConnected(
|
||||
state ? oauthDetailsFromConnectionState(state) : undefined,
|
||||
);
|
||||
})
|
||||
.catch(() => {
|
||||
// The read failed (backend down, 401 on the API token, malformed
|
||||
// stored state). Clear rather than keep the last successful read —
|
||||
// a stale answer is indistinguishable from a fresh one in the panel.
|
||||
if (cancelled) return;
|
||||
setConnectionInfoOAuthWhenConnected(undefined);
|
||||
});
|
||||
};
|
||||
|
||||
const onAmbientAuthChallenge = (): void => {
|
||||
|
|
|
|||
Loading…
Reference in a new issue