fix: terminate the OAuth connection-details refresh promise chain
The connection-details refresh effect in useOAuthRecovery voided inspectorClient.getOAuthState() with a lone .then and no rejection handler. In the browser that read goes through the remote OAuth store, so it is a network round trip that can reject — a backend that is down or restarting, a 401 on the API token, malformed stored state. void silences no-floating-promises without terminating anything, so every such failure became an unhandled rejection, on the initial refresh and on every oauthComplete refresh. Terminate the chain with a .catch that clears the panel details rather than leaving the last successful read on screen: the panel reports the current OAuth state, and a stale answer is indistinguishable from a fresh one. The cancelled guard is repeated on the catch so a rejection arriving after unmount does not write. The void stays, now with the one-line justification AGENTS.md asks for — a synchronous useEffect body cannot await. Two tests cover it. Both fail against the unfixed source with unhandled rejections, which is the failure mode itself: an unhandled rejection fails the whole vitest run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GBkPzbuxgyqiz39ytmQzMB Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
fe35885b08
commit
19a39235a2
2 changed files with 65 additions and 6 deletions
|
|
@ -393,6 +393,54 @@ describe("useOAuthRecovery", () => {
|
||||||
expect(h.api().connectionInfoOAuth).toBeUndefined();
|
expect(h.api().connectionInfoOAuth).toBeUndefined();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("clears the details when the state read rejects", async () => {
|
||||||
|
const client = fakeClient({
|
||||||
|
getOAuthState: vi.fn().mockRejectedValue(new Error("backend down")),
|
||||||
|
});
|
||||||
|
const props: HarnessProps = {
|
||||||
|
servers: [entry("a")],
|
||||||
|
activeServerId: "a",
|
||||||
|
client,
|
||||||
|
};
|
||||||
|
const h = harness(props);
|
||||||
|
await waitFor(() => expect(client.getOAuthState).toHaveBeenCalled());
|
||||||
|
expect(h.api().connectionInfoOAuth).toBeUndefined();
|
||||||
|
|
||||||
|
// The rejection is terminated, not floated: a later resolving read still
|
||||||
|
// populates the panel, which an unhandled rejection would have prevented
|
||||||
|
// by failing the run.
|
||||||
|
client.getOAuthState = vi
|
||||||
|
.fn()
|
||||||
|
.mockResolvedValue({ tokens: { access_token: "t" } });
|
||||||
|
await act(async () => {
|
||||||
|
client.emit("oauthComplete", {});
|
||||||
|
});
|
||||||
|
await waitFor(() => expect(h.api().connectionInfoOAuth).toBeDefined());
|
||||||
|
});
|
||||||
|
|
||||||
|
it("drops a rejected state read that lands after the session ended", async () => {
|
||||||
|
let fail: (reason: unknown) => void = () => {};
|
||||||
|
const client = fakeClient({
|
||||||
|
getOAuthState: vi.fn(
|
||||||
|
() =>
|
||||||
|
new Promise((_resolve, reject) => {
|
||||||
|
fail = reject;
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
});
|
||||||
|
const props: HarnessProps = {
|
||||||
|
servers: [entry("a")],
|
||||||
|
activeServerId: "a",
|
||||||
|
client,
|
||||||
|
};
|
||||||
|
const h = harness(props);
|
||||||
|
h.rerender({ ...props, connectionStatus: "disconnected" });
|
||||||
|
await act(async () => {
|
||||||
|
fail(new Error("backend down"));
|
||||||
|
});
|
||||||
|
expect(h.api().connectionInfoOAuth).toBeUndefined();
|
||||||
|
});
|
||||||
|
|
||||||
it("drops a state read that lands after the session ended", async () => {
|
it("drops a state read that lands after the session ended", async () => {
|
||||||
let settle: (value: unknown) => void = () => {};
|
let settle: (value: unknown) => void = () => {};
|
||||||
const client = fakeClient({
|
const client = fakeClient({
|
||||||
|
|
|
||||||
|
|
@ -406,11 +406,22 @@ export function useOAuthRecovery({
|
||||||
let cancelled = false;
|
let cancelled = false;
|
||||||
|
|
||||||
const refresh = (): void => {
|
const refresh = (): void => {
|
||||||
void inspectorClient.getOAuthState().then((state) => {
|
// void: a synchronous useEffect body cannot await. The chain is
|
||||||
|
// terminated below, so the rejection is handled rather than discarded.
|
||||||
|
void inspectorClient
|
||||||
|
.getOAuthState()
|
||||||
|
.then((state) => {
|
||||||
if (cancelled) return;
|
if (cancelled) return;
|
||||||
setConnectionInfoOAuthWhenConnected(
|
setConnectionInfoOAuthWhenConnected(
|
||||||
state ? oauthDetailsFromConnectionState(state) : undefined,
|
state ? oauthDetailsFromConnectionState(state) : undefined,
|
||||||
);
|
);
|
||||||
|
})
|
||||||
|
.catch(() => {
|
||||||
|
// The read failed (backend down, 401 on the API token, malformed
|
||||||
|
// stored state). Clear rather than keep the last successful read —
|
||||||
|
// a stale answer is indistinguishable from a fresh one in the panel.
|
||||||
|
if (cancelled) return;
|
||||||
|
setConnectionInfoOAuthWhenConnected(undefined);
|
||||||
});
|
});
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue