fix: bound the resource file name, and move its typography into the theme (#2263)

Copilot review round 9, two findings.

The Skill Resource control shows the displayed file's name, and that control is
PINNED — it never scrolls — so a resource URI ending in a long breakable segment
grew the header. Fifth instance of the same class.

It took three attempts, and the mutation table is what exposed each one.
`lineClamp: 1` stopped the text wrapping but the row then wrapped the caption
onto its own line (+30.6px), because flexbox wraps before it shrinks. A
`nowrap` row improved that to +21.7px but Mantine's Accordion label wrapper
still would not let the caption shrink, so `miw: 0` had nothing to act on. A
hard `maw: "50%"` gives the ellipsis a definite width, and the control now grows
by 0px.

Worth recording that the FIRST version of that guard passed against the defect:
it asserted an absolute `height < 120px`, which an unclamped name satisfies
because it only wraps to a few lines. Comparing the control against its own
baseline — measured with a short name, then re-measured after selecting the
hostile one — is what makes it detect anything at all.

Second finding: `SkillDescription` carried `size: "sm"`, leaving typography at
the call site directly beneath a comment of mine asserting that these constants
carry layout only and that typography belongs in a `ThemeText` variant. Added a
`skillDescription` variant; only the clamp stays here.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R4441JdNLZerCVM7mDDSfB
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-06 02:23:43 -04:00
commit 1a2e375379

View file

@ -293,10 +293,41 @@ const SkillUriCaption = Text.withProps({
// documents. Three lines is enough to read a real description; the full text
// stays available through the native `title` tooltip the call site passes.
const SkillDescription = Text.withProps({
size: "sm",
variant: "skillDescription",
lineClamp: 3,
});
// The Skill Resource control's row. `nowrap` is load-bearing: flexbox wraps
// BEFORE it shrinks, so in a wrapping row a long file name pushes itself onto a
// second line and grows the pinned control no matter how the caption is
// clamped. With nowrap the caption's `miw: 0` can take effect and it ellipsizes
// instead.
const ResourceHeaderRow = Group.withProps({
justify: "space-between",
wrap: "nowrap",
gap: "sm",
w: "100%",
});
// The displayed file's name, in the Skill Resource section's CONTROL — which is
// pinned and therefore does not scroll, so a resource URI ending in a very long
// breakable segment would grow the header itself. One line, with the full name
// on the `title` the call site passes.
const ResourceNameCaption = Text.withProps({
variant: "monoCaption",
// `truncate` alone is not enough: the caption sits in a wrapping header row,
// so a long name whose MIN-CONTENT width exceeds the space simply pushes
// itself onto a second line and grows the control anyway. `miw: 0` lets flex
// shrink it below that width, which is what actually engages the ellipsis.
truncate: "end",
// `miw: 0` alone was not enough — Mantine's Accordion label wrapper does not
// let the row shrink, so the caption kept its content width and grew the
// control anyway. A hard cap gives the ellipsis a definite width to work
// against, which is what actually bounds the pinned header.
miw: 0,
maw: "50%",
});
const IssueStack = Stack.withProps({
gap: "xs",
});
@ -1570,12 +1601,14 @@ export function SkillsScreen({
}
>
<Accordion.Control>
<SectionControlsRow>
<ResourceHeaderRow>
<SectionHeading>Skill Resource</SectionHeading>
{previewUri !== undefined && (
<MonoCaption>{resourceFileName(previewUri)}</MonoCaption>
<ResourceNameCaption title={previewUri}>
{resourceFileName(previewUri)}
</ResourceNameCaption>
)}
</SectionControlsRow>
</ResourceHeaderRow>
</Accordion.Control>
<Accordion.Panel
tabIndex={0}