modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

docs: state the Storybook browser-pool exception (#2336)

Browse source 
Copilot review round 1: "every project inherits availableParallelism() - 1"
overstated the scope. The five forks-pool projects do; web's storybook
project runs the browser pool, whose default is min(12, availableParallelism()
- 1) — the same 7 on this machine, but a different expression, capped on
larger machines and 1 unless headless — and none of the arms measured it. A
maxWorkers set on that project would still apply (getThreadsCount reads it
first), so it is not exempt from the decision, only unmeasured; both files
now say so.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-13 00:25:07 -04:00
commit 1c243377be
1 changed files with 20 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
vitest.shared.mts
View file

@ -81,9 +81,20 @@ export const INTEGRATION_TIMEOUTS = Object.freeze({
/**
* `maxWorkers` is deliberately unset, here and in every project (#2336).
*
* Each project therefore inherits Vitest's non-watch default,
* `availableParallelism() - 1` — 7 on the eight-logical-core M3 this team
* works on. Keeping it is a choice, not an omission, and this is the
* The five forks-pool projects — web `unit` and `integration`, `cli`, `tui`,
* `launcher` — therefore inherit Vitest's non-watch default,
* `availableParallelism() - 1`: 7 on the eight-logical-core M3 this team
* works on. Web's `storybook` project is the exception: it runs the browser
* pool, whose default is a different expression,
* `min(12, availableParallelism() - 1)` — also 7 here, but capped on larger
* machines because the main thread chokes past ~12 browser workers
* (vitest#7871) — and 1 unless the run is headless with file parallelism. A
* `maxWorkers` set on that project *would* apply to it (`getThreadsCount`
* reads it before falling back), so it is not exempt from this decision;
* but nothing below measured it. The numbers are the forks pool's, and a cap
* for Storybook would need its own measurement.
*
* Keeping the default is a choice, not an omission, and this is the
* measurement it rests on. On `v2/main` @ `f16a51d4` — after the gate lease
* (#2339) — with the arms interleaved (default / `--maxWorkers=4` / default),
* three rounds, one worktree, nothing else of ours running: