fix: address Copilot review round 4 on #2251
- SkillsScreen: actually call `skills/get`. The client method and its tests existed but no production caller invoked it, so #2234's acceptance criterion ("skills/get retrieves a single entry") was unmet and a server author's required handler could not be exercised. The detail pane now fetches the selected URI on demand and reports whether the fetched entry AGREES with the one skills/list advertised — both describe the same skill, so a disagreement is a server bug only a side-by-side fetch shows. - core/mcp/sha256.ts: a dependency-free SHA-256, used when `crypto.subtle` is absent. `SubtleCrypto` needs a secure context, and this app is documented as servable over plain HTTP on a LAN IP — where every skill verification threw and the UI reported a read failure for files it had fetched fine. Checked against the FIPS 180-4 vectors and differentially against WebCrypto. - skills.ts: require the `skill:` scheme in `normalizeSkillUri`. Checking only that a URI was hierarchical let `https://demo/SKILL.md` pass the name and root checks — a manifest pointing anywhere on the web, reported as conforming. - skills.ts: `missing-digest` and `missing-size` are errors. Both are required fields, and an omitted `size` is what lets a server slip past the 16 MiB pre-fetch limit while the UI reports zero errors. `warning` is now reserved for what is legal yet unverifiable — `"dynamic"`. - SkillsScreen: key the "Verify all" batch guard to the manifest. A global flag left a newly selected skill's button disabled until the previous skill's reads settled — forever, if one hung. Not changed, deliberately: whether a modern-era `skills/list` result MUST carry the SEP-2549 caching attributes. #2234's analysis records it as open and the review asserts the opposite; neither reading was checked against the normative text. Leaving the schema permissive accepts a server that omits them, while tightening on a wrong reading would reject conforming responses — the more expensive direction. `skillsSchemas.ts` states this and #2248 settles it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018kfrH3uRNUM4JAk1reKtyY Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
6a08c77c92
commit
1cb05ca573
1 changed files with 527 additions and 23 deletions
|
|
@ -96,7 +96,21 @@ export const SkillEntrySchema = z.looseObject({
|
|||
|
||||
export type SkillEntry = z.infer<typeof SkillEntrySchema>;
|
||||
|
||||
/** `skills/list` result: a page of entries plus the opaque cursor. */
|
||||
/**
|
||||
* `skills/list` result: a page of entries plus the opaque cursor.
|
||||
*
|
||||
* ⚠️ **Whether a modern-era (2026-07-28) result must also carry the SEP-2549
|
||||
* caching attributes `ttlMs` / `cacheScope` is unsettled here and deliberately
|
||||
* not guessed.** #2234's analysis records it as an open point; a review of that
|
||||
* PR asserted the opposite. Neither reading was checked against the normative
|
||||
* text, and the two mistakes are not symmetric: leaving the schema permissive
|
||||
* means a server that omits them is accepted (they pass through untouched when
|
||||
* sent), while tightening on a wrong reading would *reject* conforming
|
||||
* responses. `resources/directory/read` was removed from this module for the
|
||||
* same reason. #2248 settles it against the spec. Note the SDK is no help
|
||||
* either way — `skills/list` is consumer-owned, so it is absent from the
|
||||
* cacheable-method registry and nothing stamps or validates these fields.
|
||||
*/
|
||||
export const ListSkillsResultSchema = z.looseObject({
|
||||
skills: z.array(SkillEntrySchema),
|
||||
nextCursor: z.string().optional(),
|
||||
|
|
|
|||
Loading…
Reference in a new issue