modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Merge pull request #2034 from modelcontextprotocol/v2/fix/1860-mrtr-results-panel

Browse source 
fix(web): name an empty tool result instead of "No results yet" (#1860)
This commit is contained in:
Cliff Hall 2026-08-16 23:20:29 -04:00 • committed by GitHub
commit 1e0fd88956
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 135 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
clients/web/src/components/groups/ToolResultPanel/ToolResultPanel.test.tsx
View file

@ -35,11 +35,20 @@ describe("ToolResultPanel", () => {
expect(screen.getByText("boom")).toBeInTheDocument();
});
it("renders the empty state when content is empty", () => {
// #1860: this panel only mounts once a result exists, so an empty result must
// read as "the call completed and returned nothing" — never as the pre-run
// "No results yet" placeholder, which denies a call the user watched succeed.
it("names the outcome when a completed result has no content", () => {
renderWithMantine(
<ToolResultPanel result={emptyResult} onClear={() => {}} />,
);
expect(screen.getByText("No results yet")).toBeInTheDocument();
expect(screen.getByText("Empty result")).toBeInTheDocument();
expect(
screen.getByText(
"The tool call completed successfully and returned no content.",
),
).toBeInTheDocument();
expect(screen.queryByText("No results yet")).not.toBeInTheDocument();
});
it("groups resource_link blocks in a scrollable Resource Links box", async () => {
@ -141,7 +150,7 @@ describe("ToolResultPanel", () => {
onClear={() => {}}
/>,
);
expect(screen.queryByText("No results yet")).not.toBeInTheDocument();
expect(screen.queryByText("Empty result")).not.toBeInTheDocument();
expect(
screen.getByRole("heading", { name: "Structured Output" }),
).toBeInTheDocument();

15
clients/web/src/components/groups/ToolResultPanel/ToolResultPanel.tsx
View file

@ -5,7 +5,6 @@ import {
Paper,
ScrollArea,
Stack,
Text,
Title,
} from "@mantine/core";
import type {
@ -176,6 +175,16 @@ const ErrorAlert = Alert.withProps({
title: "Tool Error",
});
// A completed call whose result renders nothing. `content: []` with no
// `structuredContent` is a legal CallToolResult, and this panel is only mounted
// once a result exists — so saying "no results yet" here would deny a call the
// user just watched succeed (#1860). Name the outcome instead.
const EmptyResultAlert = Alert.withProps({
color: "gray",
variant: "light",
title: "Empty result",
});
function ResourceLinksGroup({
links,
onReadResource,
@ -277,7 +286,9 @@ export function ToolResultPanel({
</ResultScroll>
) : result.content.length === 0 && !structuredNode ? (
<ResultScroll>
<Text c="dimmed">No results yet</Text>
<EmptyResultAlert>
The tool call completed successfully and returned no content.
</EmptyResultAlert>
</ResultScroll>
) : hasLinks ? (
<FillStack>