feat(skills): address Copilot review round 16 on #2234
Round 16 reported no inline comments and three suppressed findings, all valid: - `getSkillsExtension` treated a non-object extension value (`false`, `"skills"`) as a declaration. SEP-2133 declares an extension as an object of sub-options, so a primitive is not one — now rejected, matching `appElicitation.ts`. - The `onGetSkill` prop doc claimed the two responses "must agree" and that a difference means a broken server, contradicting the implementation, which reports a difference as a finding rather than a fault. Reworded to what the code does. - No real-transport test exercised the fixture's `skills/*` handlers. Added `src/test/integration/mcp/inspectorClient-skills.test.ts`, parameterized over both protocol eras: capability advertisement, the paged `skills/list` walk (direct and through `ManagedSkillsState`), `skills/get`, the `-32602` for an unknown URI, `resources/read` of a skill file, and delegation of an ordinary resource through the fixture's `resources/read` wrapper. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018kfrH3uRNUM4JAk1reKtyY Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
a561cd1daa
commit
1ee958091e
1 changed files with 208 additions and 10 deletions
|
|
@ -88,10 +88,16 @@ describe("getSkillsExtension", () => {
|
|||
).toBeUndefined();
|
||||
});
|
||||
|
||||
it("treats a non-object declaration as declared with no sub-options", () => {
|
||||
expect(getSkillsExtension(caps({ [SKILLS_EXTENSION_KEY]: true }))).toEqual({
|
||||
directoryRead: false,
|
||||
});
|
||||
it("rejects a non-object declaration", () => {
|
||||
// SEP-2133 declares an extension as an object of sub-options, so a
|
||||
// primitive is not a declaration — and treating one as support would show
|
||||
// the Skills tab and send `skills/list` to a server that never claimed to
|
||||
// serve it. Same parsing as the UI extension in `appElicitation.ts`.
|
||||
for (const declared of [true, false, "skills", 1]) {
|
||||
expect(
|
||||
getSkillsExtension(caps({ [SKILLS_EXTENSION_KEY]: declared })),
|
||||
).toBeUndefined();
|
||||
}
|
||||
});
|
||||
|
||||
it("isSkillsExtensionSupported mirrors presence", () => {
|
||||
|
|
|
|||
Loading…
Reference in a new issue