fix(auth): address review — proxy CIMD discovery fetch, validate metadata path
Two findings from review: - `ensureCimdClientRegistration` ran protected-resource discovery on the global fetch while its AS-metadata leg used the configured one. On web that is `createRemoteFetch`, which proxies through the backend to sidestep CORS — so the discovery this PR routes to a challenge-advertised URL would fail in the browser, be swallowed by the catch, and leave CIMD probing the wrong authorization server. Forward `params.fetchFn`, and assert in the test that nothing reaches the global. - `oauth.resourceMetadataPath` accepted `//other-host/doc`. Resolved against the request base that re-points the origin in the advertised `resource_metadata` while Express still registers the route locally, so the server would advertise a document it does not serve. `/\\host` does the same, since the URL parser folds a backslash into a slash for special schemes — a leading-slash check misses both. Validate origin-relativity with a shared predicate, used by the JSON-config validator and again at server setup for a programmatically built ServerConfig. Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
f8a46726b7
commit
2a0290df26
1 changed files with 107 additions and 31 deletions
|
|
@ -17,6 +17,7 @@ import {
|
|||
TestServerHttp,
|
||||
getDefaultServerConfig,
|
||||
createOAuthTestServerConfig,
|
||||
isOriginRelativePath,
|
||||
loadConfig,
|
||||
resolveConfig,
|
||||
waitForOAuthWellKnown,
|
||||
|
|
@ -103,4 +104,20 @@ describe("OAuth challenge resource_metadata (RFC 9728)", () => {
|
|||
resourceMetadataPath: METADATA_PATH,
|
||||
});
|
||||
});
|
||||
|
||||
it.each([
|
||||
["/custom/protected-resource", true],
|
||||
["/a", true],
|
||||
// Both re-point the origin when resolved against the request base while
|
||||
// Express still registers the route locally, so the server would advertise
|
||||
// a document it does not serve (Copilot).
|
||||
["//other-host/doc", false],
|
||||
["/\\other-host/doc", false],
|
||||
["https://other-host/doc", false],
|
||||
["custom/protected-resource", false],
|
||||
["/has a space", false],
|
||||
["", false],
|
||||
])("origin-relative path check: %j -> %s", (value, expected) => {
|
||||
expect(isOriginRelativePath(value)).toBe(expected);
|
||||
});
|
||||
});
|
||||
|
|
|
|||
Loading…
Reference in a new issue