* feat(web): add View Source toggle to resource preview (closes #1552) Markdown, CSV, and HTML resources render in a way that hides the underlying text (react-markdown, the CSV table, the sandboxed HTML iframe). Add a "View Source" button to the resource preview footer, left of Refresh and styled to match it, that swaps the rendered preview for the raw resource text. In source mode the button reads "View Rendered". - Only shown for markdown/csv/html (other kinds already show their text, or have no meaningful text source). - Source mode forces ContentViewer through its plain-text renderer; the displayed MIME label keeps the resource's real type. - The toggle resets to the rendered view when the previewed resource changes (React's adjust-state-during-render pattern — no effect). Tests cover the toggle round-trip, per-kind visibility, and the reset; a Storybook play function exercises rendered → source → rendered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(web): address View Source review nits (#1553) - Per-item source gating: in source mode only source-toggleable items switch to plain text, so a mixed multi-part resource doesn't force an image/PDF blob through the text decoder. - Share a FooterButton constant between Refresh and the View Source toggle so the two stay visually identical (per the subcomponent guidance — both had the same two inline props). - Add aria-pressed to the toggle so assistive tech gets explicit on/off state beyond the label flip. Tests added for the aria-pressed state and the mixed multi-part case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
baf79b843f
commit
2a60ac5dce
1 changed files with 264 additions and 12 deletions
|
|
@ -8,6 +8,7 @@ import {
|
|||
Text,
|
||||
Title,
|
||||
} from "@mantine/core";
|
||||
import { useState } from "react";
|
||||
import type {
|
||||
BlobResourceContents,
|
||||
Resource,
|
||||
|
|
@ -15,6 +16,7 @@ import type {
|
|||
} from "@modelcontextprotocol/sdk/types.js";
|
||||
import { AnnotationBadge } from "../../elements/AnnotationBadge/AnnotationBadge";
|
||||
import { ContentViewer } from "../../elements/ContentViewer/ContentViewer";
|
||||
import { getMimeKind } from "../../elements/ContentViewer/contentViewerUtils";
|
||||
import { CopyButton } from "../../elements/CopyButton/CopyButton";
|
||||
import { SubscribeButton } from "../../elements/SubscribeButton/SubscribeButton";
|
||||
|
||||
|
|
@ -44,6 +46,19 @@ function formatLastUpdated(date: Date): string {
|
|||
return `Last updated: ${date.toLocaleString()}`;
|
||||
}
|
||||
|
||||
// MIME kinds whose rendered preview (react-markdown, the CSV table, the
|
||||
// sandboxed HTML iframe) hides the underlying text. For these the panel offers
|
||||
// a "View Source" toggle that swaps the renderer for the raw resource text.
|
||||
const SOURCE_TOGGLEABLE_KINDS = new Set(["markdown", "csv", "html"]);
|
||||
|
||||
// MIME forced on ContentViewer in source mode so it routes through the plain
|
||||
// preformatted-text renderer regardless of the resource's real type.
|
||||
const SOURCE_MIME = "text/plain";
|
||||
|
||||
function isSourceToggleable(mimeType: string): boolean {
|
||||
return SOURCE_TOGGLEABLE_KINDS.has(getMimeKind(mimeType));
|
||||
}
|
||||
|
||||
const HeaderRow = Group.withProps({
|
||||
justify: "space-between",
|
||||
wrap: "nowrap",
|
||||
|
|
@ -95,6 +110,14 @@ const ActionGroup = Group.withProps({
|
|||
gap: "xs",
|
||||
});
|
||||
|
||||
// Subtle footer action button. Shared by Refresh and the View Source toggle so
|
||||
// the two stay visually identical (the toggle is deliberately styled to match
|
||||
// Refresh, which sits immediately to its right).
|
||||
const FooterButton = Button.withProps({
|
||||
variant: "subtle",
|
||||
size: "sm",
|
||||
});
|
||||
|
||||
const Spacer = Flex.withProps({});
|
||||
|
||||
// The panel sizes to its content: when the resource body is short the
|
||||
|
|
@ -180,6 +203,17 @@ export function ResourcePreviewPanel({
|
|||
const { uri, annotations } = resource;
|
||||
const mimeType = effectiveMime(contents[0]?.mimeType, resource);
|
||||
|
||||
const [showSource, setShowSource] = useState(false);
|
||||
// Reset to the rendered view when the previewed resource changes (the panel
|
||||
// is reused, not remounted, across resources). React's documented
|
||||
// "adjust state during render" pattern — no effect, so no cascading render.
|
||||
const [prevUri, setPrevUri] = useState(uri);
|
||||
if (uri !== prevUri) {
|
||||
setPrevUri(uri);
|
||||
setShowSource(false);
|
||||
}
|
||||
const sourceToggleable = isSourceToggleable(mimeType);
|
||||
|
||||
return (
|
||||
<PanelStack>
|
||||
<HeaderRow>
|
||||
|
|
@ -196,14 +230,26 @@ export function ResourcePreviewPanel({
|
|||
</HeaderRow>
|
||||
<ContentScroll>
|
||||
<ContentStack>
|
||||
{contents.map((item, index) => (
|
||||
<ContentViewer
|
||||
key={index}
|
||||
contents={item}
|
||||
mimeType={effectiveMime(item.mimeType, resource)}
|
||||
copyable
|
||||
/>
|
||||
))}
|
||||
{contents.map((item, index) => {
|
||||
const itemMime = effectiveMime(item.mimeType, resource);
|
||||
// The toggle is gated on the first content item but applies per
|
||||
// item: in source mode only the source-toggleable items (the ones
|
||||
// whose rendered view hides their text) switch to plain text, so a
|
||||
// mixed multi-part resource doesn't force an image/PDF blob through
|
||||
// the text decoder.
|
||||
const renderMime =
|
||||
showSource && isSourceToggleable(itemMime)
|
||||
? SOURCE_MIME
|
||||
: itemMime;
|
||||
return (
|
||||
<ContentViewer
|
||||
key={index}
|
||||
contents={item}
|
||||
mimeType={renderMime}
|
||||
copyable
|
||||
/>
|
||||
);
|
||||
})}
|
||||
</ContentStack>
|
||||
</ContentScroll>
|
||||
<MetaRow>
|
||||
|
|
@ -224,9 +270,15 @@ export function ResourcePreviewPanel({
|
|||
)}
|
||||
</AnnotationGroup>
|
||||
<ActionGroup>
|
||||
<Button variant="subtle" size="sm" onClick={onRefresh}>
|
||||
Refresh
|
||||
</Button>
|
||||
{sourceToggleable && (
|
||||
<FooterButton
|
||||
aria-pressed={showSource}
|
||||
onClick={() => setShowSource((shown) => !shown)}
|
||||
>
|
||||
{showSource ? "View Rendered" : "View Source"}
|
||||
</FooterButton>
|
||||
)}
|
||||
<FooterButton onClick={onRefresh}>Refresh</FooterButton>
|
||||
{subscriptionsSupported && (
|
||||
<SubscribeButton
|
||||
subscribed={isSubscribed}
|
||||
|
|
|
|||
Loading…
Reference in a new issue